Stream package extraction to bound peak memory usage - #410
Open
joaogabriel15 wants to merge 1 commit into
Open
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
zooba
reviewed
Sep 9, 2026
| with open(dest, "wb") as f: | ||
| f.write(zf.read(member)) | ||
| with zf.open(member) as source, open(dest, "wb") as f: | ||
| shutil.copyfileobj(source, f, length=1024 * 1024) |
Member
There was a problem hiding this comment.
How badly does it affect the maximum memory usage if we make this use 10MB instead of 1MB? I'd like our standard Python distributions to still only use one call per file, and the biggest file we include is (currently) around 7MB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #409.
Extract ZIP members in 1 MiB chunks instead of materializing each uncompressed member in memory. Destination validation, repair behavior, overwrite warnings, and progress reporting are unchanged.
Adds regression coverage for ZIP and NuGet archives, multi-chunk files, empty files, existing files, and repair. The four new cases fail against the original extraction function and pass with the change.
Validation on Windows, CPython 3.14.3: