Skip to content

Hide the top menu on mobile #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugovk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hide the top menu on mobile #3198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions static/css/mq.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,20 @@ html[xmlns] .slides { display: block; }
.no-touch .default-page .main-navigation {
position: relative;
margin-bottom: -.0625em; } }
/* - - - Smaller than 640px - - - */
/* Hide the top menu on small screens. Only the list is hidden so the
"Skip to content" link inside the nav stays available to assistive tech.
#top stays as an empty, zero-height block so "Back to Top" links still
have a target. */
@media (max-width: 39.9375em) {
.top-bar {
border-bottom: 0; }
.top-bar .menu {
display: none; }
/* The header's dark top border is now the first pixel on the page,
so drop it too */
.main-header {
border-top: 0; } }
/* - - - Larger than 640px - - - */
@media (min-width: 40em) {
body:after {
Expand Down Expand Up @@ -734,8 +748,6 @@ html[xmlns] .slides { display: block; }
.meta-navigation .say-no-more {
display: none;
visibility: hidden; }
.meta-navigation .jump-link {
display: none; }
.meta-navigation li {
float: left;
width: 16.6666667%;
Expand Down
2 changes: 0 additions & 2 deletions static/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,8 +1027,6 @@ h2.not-column {
.meta-navigation .say-no-more {
display: inline;
visibility: visible; }
.meta-navigation .jump-link {
background-color: #11171d; }

/* Used in both the main-header and the header-banner */
.main-header {
Expand Down
13 changes: 1 addition & 12 deletions static/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,19 +182,8 @@ $().ready(function() {
}
/* Animate some scrolling for smoother transitions */

/* ! Not currently working in IE10/Windows 8, Chrome for Android, Firefox (all versions)... something about the animate() function */
$("#close-python-network").click(function() {
$('body, html').animate({ scrollTop: $('#python-network').offset().top }, 300);
return false;
});

$("#python-network").click(function() {
$('body, html').animate({ scrollTop: $('#top').offset().top }, 300);
return false;
});

$("#back-to-top-1, #back-to-top-2").click(function() {
$('body, html').animate({ scrollTop: $('#python-network').offset().top }, 500);
$('body, html').animate({ scrollTop: $('#top').offset().top }, 500);
return false;
});

Expand Down
13 changes: 2 additions & 11 deletions templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,17 +136,8 @@
<a href="#content" title="Skip to content">Skip to content</a>
</div>

{# Fallback for browsers that do not display generated content... HTML entity will be the icon instead #}
<a id="close-python-network" class="jump-link" href="#python-network" aria-hidden="true">
<span aria-hidden="true" class="icon-arrow-down"><span>&#9660;</span></span> Close
</a>

{% sitetree_menu from "main" include "trunk" template "sitetree/top.html" %}

<a id="python-network" class="jump-link" href="#top" aria-hidden="true">
<span aria-hidden="true" class="icon-arrow-up"><span>&#9650;</span></span> The Python Network
</a>

</nav>

</div>
Expand Down Expand Up @@ -260,11 +251,11 @@
<div class="container">

{% block footer_sitemap %}
<a id="back-to-top-1" class="jump-link" href="#python-network"><span aria-hidden="true" class="icon-arrow-up"><span>&#9650;</span></span> Back to Top</a>
<a id="back-to-top-1" class="jump-link" href="#top"><span aria-hidden="true" class="icon-arrow-up"><span>&#9650;</span></span> Back to Top</a>

{% sitetree_menu from "main" include "python-meta" template "sitetree/footer.html" %}

<a id="back-to-top-2" class="jump-link" href="#python-network"><span aria-hidden="true" class="icon-arrow-up"><span>&#9650;</span></span> Back to Top</a>
<a id="back-to-top-2" class="jump-link" href="#top"><span aria-hidden="true" class="icon-arrow-up"><span>&#9650;</span></span> Back to Top</a>
{% endblock footer_sitemap %}

</div><!-- end .container -->
Expand Down
Loading