Skip to content

Use stricter pyright settings on pyogrio #16017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexWaygood wants to merge 3 commits into from
+4 −3
Closed

Use stricter pyright settings on pyogrio #16017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e96b000
Use stricter pyright settings on `pyogrio`
AlexWaygood Jul 15, 2026
1cb9b01
hmm
AlexWaygood Jul 15, 2026
b45033f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyrightconfig.stricter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
"stubs/pyasn1",
"stubs/Pygments",
"stubs/PyMySQL",
"stubs/pyogrio",
"stubs/python-jose",
"stubs/pywin32",
"stubs/PyYAML",
Expand Down
6 changes: 4 additions & 2 deletions stubs/pyogrio/pyogrio/raw.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
*,
batch_size: int = 65536, # Extracted from kwargs
**kwargs: Any, # Dataset open options passed to OGR
) -> tuple[_Meta, pa.Table]: ...
) -> tuple[_Meta, pa.Table]: ... # pyright: ignore[reportUnknownMemberType] # pyarrow is an optional dependency

Check failure on line 91 in stubs/pyogrio/pyogrio/raw.pyi

View workflow job for this annotation

GitHub Actions / pyright: Run test cases (Linux, 3.13) 

Unnecessary "# pyright: ignore" rule: "reportUnknownMemberType" (reportUnnecessaryTypeIgnoreComment)

@overload
def open_arrow(
Expand Down Expand Up @@ -136,7 +136,9 @@
use_pyarrow: Literal[True],
datetime_as_string: bool = False,
**kwargs: Any, # Dataset open options passed to OGR
) -> AbstractContextManager[tuple[_Meta, pa.RecordBatchReader]]: ...
) -> AbstractContextManager[
tuple[_Meta, pa.RecordBatchReader]
]: ... # pyright: ignore[reportUnknownMemberType] # pyarrow is an optional dependency

Check failure on line 141 in stubs/pyogrio/pyogrio/raw.pyi

View workflow job for this annotation

GitHub Actions / pyright: Run test cases (Linux, 3.13) 

Unnecessary "# pyright: ignore" rule: "reportUnknownMemberType" (reportUnnecessaryTypeIgnoreComment)

def write(
path: WritePathOrBuffer,
Expand Down
Loading