[aiofiles] Fix NamedTemporaryFile name type - #16357
Open
nightcityblade wants to merge 2 commits into
Open
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
requested changes
Sep 10, 2026
| @type_check_only | ||
| class _NamedAsyncTextIOWrapper(AsyncTextIOWrapper, Generic[AnyStr]): | ||
| @property | ||
| def name(self) -> AnyStr: ... |
Collaborator
There was a problem hiding this comment.
Considering these all derive from _UnknownAsyncBinaryIO or _UnknownAsyncTextIO, I think a better approach is to make these classes and their sub-classes generic over name.
_NameT = TypeVar("_NameT", bound=FileDescriptorOrPath, default=FileDescriptorOrPath)| loop: AbstractEventLoop | None = None, | ||
| executor: Executor | None = None, | ||
| ) -> AiofilesContextManager[AsyncTextIOWrapper]: ... | ||
| ) -> AiofilesContextManager[_NamedAsyncTextIOWrapper[AnyStr]]: ... |
Collaborator
There was a problem hiding this comment.
I don't think using AnyStr here or in the other branches is correct. For one, if neither suffix or prefix is given, AnyStr is unbound. Also the name attribute of the wrapped temporary file object always seems to to be str. This would require further investigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13551. Replaces #16162 after its branch history was repaired.
Models the path-dependent
nameattribute on wrappers returned byaiofiles.tempfile.NamedTemporaryFile(), preservingbyteswhen bytes path arguments are supplied while retainingstrfor string paths.OpenAI Codex was used to prepare this change.