Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18805
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (4 Unrelated Failures)As of commit c064deb with merge base 5e8a0df ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Fixes a crash during backend delegate initialization when the FlatBuffer compile_specs field is absent (optional in schema) by treating it as an empty compile spec list.
Changes:
- Add a null check for
delegate.compile_specs()before populating and sizing compile specs. - Default to
compile_specs = nullptrandnum_compile_specs = 0so backends receive an emptyArrayRef<CompileSpec>when unspecified.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The FlatBuffer schema defines compile_specs as optional, but the code unconditionally dereferenced it. Add a null check so delegates without compile_specs get initialized with an empty spec list instead of crashing. Addresses TOB-EXECUTORCH-38. This PR was authored with the assistance of Claude.
The FlatBuffer schema defines compile_specs as optional, but the code unconditionally dereferenced it. Add a null check so delegates without compile_specs get initialized with an empty spec list instead of crashing.
This PR was authored with the assistance of Claude.