Skip to content

Disable mean fallback op (#18815)#18815

Open
mcremon-meta wants to merge 1 commit intomainfrom
export-D100258757
Open

Disable mean fallback op (#18815)#18815
mcremon-meta wants to merge 1 commit intomainfrom
export-D100258757

Conversation

@mcremon-meta
Copy link
Copy Markdown
Contributor

@mcremon-meta mcremon-meta commented Apr 10, 2026

Summary:

POR models (and virtually anything else that I've seen) only use mean on floats. Removing the fallback by default saves 75.6kB in .text.

Differential Revision: D100258757

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18815

Note: Links to docs will display an error until the docs builds have been completed.

❌ 18 New Failures, 1 Cancelled Job, 1 Pending, 1 Unrelated Failure

As of commit ed75b5f with merge base 2c545f8 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 10, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100258757.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot changed the title Disable mean fallback op Disable mean fallback op (#18815) Apr 13, 2026
meta-codesync bot pushed a commit that referenced this pull request Apr 13, 2026
Summary:

POR models (and virtually anything else that I've seen) only use mean on floats. Removing the fallback by default saves 75.6kB in .text.

Differential Revision: D100258757
@meta-codesync meta-codesync bot force-pushed the export-D100258757 branch from 15ef4bc to bb9f174 Compare April 13, 2026 04:30
mcremon-meta added a commit that referenced this pull request Apr 13, 2026
Summary:
Pull Request resolved: #18815

POR models (and virtually anything else that I've seen) only use mean on floats. Removing the fallback by default saves 75.6kB in .text.

Differential Revision: D100258757
meta-codesync bot pushed a commit that referenced this pull request Apr 14, 2026
Summary:

POR models (and virtually anything else that I've seen) only use mean on floats. Removing the fallback by default saves 75.6kB in .text.

Differential Revision: D100258757
@meta-codesync meta-codesync bot force-pushed the export-D100258757 branch from e5fc252 to d6296de Compare April 14, 2026 14:41
Summary:
Pull Request resolved: #18815

POR models (and virtually anything else that I've seen) only use mean on floats. Removing the fallback by default saves 75.6kB in .text.

Differential Revision: D100258757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants