Add TorchTPU entry - #2137
Add TorchTPU entry#2137ejmartinezm wants to merge 6 commits into
Conversation
✅ Deploy Preview for pytorch-dot-org-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Fixed formatting in the TorchTPU documentation and corrected the device assignment example.
Co-authored-by: LeeHowes <github@fidgetfiction.co.uk>
Co-authored-by: LeeHowes <github@fidgetfiction.co.uk>
Removed the recommendation for TCMalloc memory allocator for optimal runtime performance.
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
nit on the python string. but sounds good otherwise.
You should force push the commits in the PR ensuring they're all authored with your account that signed the CLA such that the CLA is green!
|
|
||
| ```python | ||
| import torch | ||
| device =torch.device("tpu") |
There was a problem hiding this comment.
Not sure what you want to show with this @chrishjones20 since it's not used below?
If it's just that regular device object works, I would add a quick comment mentioning it.
There was a problem hiding this comment.
Even though we aren't setting device=device in lines 35 and 36 we still have to call device = torch.device("tpu") for it to work.
You're saying just add a comment to line 33 that says that?
There was a problem hiding this comment.
we still have to call device = torch.device("tpu") for it to work.
That should not be true no. You shouldn't need to do that.
Co-authored-by: albanD <desmaison.alban@gmail.com>
This branch has not been deployed
4 participants
Warning
This repository is NOT the source of truth for the PyTorch website.
Only a very small number of files here are still actively used. Please do not submit website changes to this repo.
See the README for details, or contact the PyTorch Foundation team at ops@pytorch.org.
If your change is to one of the few files still served from this repo, please describe it below:
Description
Motivation