fix: make tokenizer metadata files optional - #693
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthrough
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change makes two tokenizer metadata files optional while preserving existing behavior and adds focused offline coverage; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changes address issue
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
config.jsonis absent by resolving the padding token ID from the tokenizer vocabularyspecial_tokens_map.jsonis absent by deriving special tokens from the tokenizer metadataTesting
pytest tests/test_common.py tests/test_preprocessor_utils.py -q(5 passed)pre-commit run --files fastembed/common/preprocessor_utils.py tests/test_preprocessor_utils.pymypy fastembed --disallow-incomplete-defs --disallow-untyped-defs --disable-error-code=import-untypedpyright tests/type_stub.pyCloses #686
All Submissions