Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeepSearchchecks the search term's type when deciding whether to skip the current object. As a result,DeepSearch([1], 1, exclude_types=[list])still findsroot[0], and excluded objects nested in dictionaries are searched too.Pass the current object to the existing exclusion check. Add regressions for excluded root containers and dictionary values, including custom objects and an unexcluded sibling.
Validation: all 69 search tests passed with 100% coverage of
search.py; Pyright, lint, and wheel/sdist checks passed. The full suite with slow tests had 1,315 passes and 8 skips. One existing macOSRLIMIT_AStest failed identically on the unchanged base before reaching package code.