Skip to content

QCLINUX: arm64: dts: qcom: monaco-evk: disable unused camera regulators#665

Open
nihal231998 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
nihal231998:monaco_reg_changes
Open

QCLINUX: arm64: dts: qcom: monaco-evk: disable unused camera regulators#665
nihal231998 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
nihal231998:monaco_reg_changes

Conversation

@nihal231998
Copy link
Copy Markdown

@nihal231998 nihal231998 commented Jun 5, 2026

vreg_cam0_2p8 and vreg_cam2_2p8 are not used on the Monaco EVK board.

Disable them to prevent unintended regulator enablement.

CRs-Fixed: 4548865

vreg_cam0_2p8 and vreg_cam2_2p8 are not used on the Monaco EVK board.
Disable them to prevent unintended regulator enablement.

Signed-off-by: Nihal Kumar Gupta <nihalkum@qti.qualcomm.com>
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4548865 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4548865

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis
Copy link
Copy Markdown

PR #665 — validate-patch

PR: #665

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #665 - QCLINUX: arm64: dts: qcom: monaco-evk: disable unused camera regulators
Upstream commit: N/A (vendor-only QCLINUX patch)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit, no upstream equivalent
Body preserves rationale Clear explanation of why regulators are disabled
Fixes tag present/correct N/A Not a fix; board configuration change
Authorship preserved Properly attributed with Signed-off-by
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-camx.dtso ⚠️ Disables 3 regulators but commit message mentions only 2

Issues

  • Commit message incomplete: The commit message states "vreg_cam0_2p8 and vreg_cam2_2p8 are not used" but the diff also disables vreg_cam1_2p8. The commit message should list all three regulators being disabled, or explain why vreg_cam1_2p8 was omitted from the description.

Verdict

Commit message should be updated to mention all three regulators (vreg_cam0_2p8, vreg_cam1_2p8, and vreg_cam2_2p8) for accuracy and completeness.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis
Copy link
Copy Markdown

PR #665 — checker-log-analyzer

PR: #665
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27015306172

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check DTB validation passed
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Subject prefix violation
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #665 - QCLINUX: arm64: dts: qcom: monaco-evk: disable unused camera regulators
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27015306172

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check DTB validation passed
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Subject prefix violation
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

❌ check-patch-compliance

Root cause: Commit subject uses QCLINUX: prefix which is not recognized as a valid prefix by the compliance checker.

Failure details:

2026-06-05T12:54:25.7092895Z Checking commit: QCLINUX: arm64: dts: qcom: monaco-evk: disable unused camera regulators
2026-06-05T12:54:25.7109736Z Commit summary does not start with a required prefix
2026-06-05T12:54:25.7126816Z ##[error]Process completed with exit code 1.

Fix:

The commit subject must start with one of the accepted prefixes. Since this is a downstream-only change (disabling unused regulators on Monaco EVK), you have two options:

  1. Remove the QCLINUX: prefix entirely (recommended for downstream-only changes):

    arm64: dts: qcom: monaco-evk: disable unused camera regulators
    
  2. Use FROMLIST: or UPSTREAM: prefix (only if this patch is posted/merged upstream):

    • FROMLIST: if posted to a mailing list but not yet merged
    • UPSTREAM: if already merged in mainline/upstream

Reproduce locally:

# Clone kernel-checkers repo
git clone https://github.com/qualcomm-linux/kernel-checkers.git

# Run check-patch-compliance
bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src /path/to/kernel \
  --base <base-commit> \
  --head <pr-head-commit>

Verdict

1 blocker to fix: Remove the QCLINUX: prefix from the commit subject, or replace it with an appropriate upstream prefix (FROMLIST:/UPSTREAM:) if this patch has upstream provenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants