Fix logonSent state when MessageStore fails to persist Logon

[aymenjam]

Problem

When the MessageStore fails to persist the outgoing Logon message (e.g. an IOException), Session#generateLogon() still marks logonSent as true, even though the Logon was never actually sent. This leaves the session in an inconsistent state.

Fixes #1302

Solution

Both generateLogon() overloads in Session.java now set logonSent based on the actual boolean result returned by sendRaw(), instead of setting it unconditionally beforehand.

Testing

Added testLogonNotMarkedAsSentWhenMessageStorePersistFails in SessionTest.java, which mocks a MessageStore that throws an IOException on persist, and verifies that logonSent remains false in that case.

All existing SessionTest tests still pass.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.79%. Comparing base (560200e) to head (de9b7ae).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1322      +/-   ##
============================================
+ Coverage     70.75%   70.79%   +0.04%     
- Complexity     2268     2270       +2     
============================================
  Files           161      161              
  Lines          9077     9077              
  Branches       1192     1192              
============================================
+ Hits           6422     6426       +4     
+ Misses         2199     2198       -1     
+ Partials        456      453       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[chrjohn]

Thanks for the PR @aymenjam 👍