Repository navigation
Conversation
dxnnv
approved these changes
Nov 3, 2026
dxnnv
left a comment
dxnnv
left a comment
There was a problem hiding this comment.
Since there's now activeWorkspace and specialWorkspace, monitor.*Workspace.active could be changed so it evaluates to "the workspace currently shown on the monitor". Otherwise, active is always false on specialWorkspace, so the property just means "is this monitor.activeWorkspace?" (which is redundant on monitor.specialWorkspace). This is more of a question on what callers should understand workspace.active to mean though; it would be a change to the existing API, so that's up to fox.
Anyways, FWIW the PR itself LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a
specialWorkspaceproperty toHyprlandMonitor. This is basically the same asactiveWorkspace, but for the open special workspace. It isnullif there is no open special workspace.Details and descisions
The special workspace is gotten via the
activespecialv2Hyprland event. This is pretty much a mirror of theactiveWorkspacelogic (it actually is exactly the same, aside from the property and source, so I created some shared helpers).