Added highlighting for additional equal signs and package names - #29
Closed
jeremy-allen wants to merge 2 commits into
Closed
jeremy-allen wants to merge 2 commits into
jeremy-allen wants to merge 2 commits into
Conversation
Member
|
Thank you and sorry for the long wait! Was about to merge it, but just noticed that a newer PR has a slightly broader fix, AFAICT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Gabor. I started working on this for Tidy Dev Day. I am happy to take any guidance or feedback you offer.
Changes:
Added highlighting for package names and additional equal sign operator tokens. I could not get the package name tokens to highlight in light purple as the Twilight theme does in the editor, so I set package names to take on the same color as operators. This addresses issue #15.
Note:
This solution was suggested by Claude Code ✨. I tested many versions in the RStudio R console and terminal, and the highlights work in both, though the terminal still uses its own color for operators (green) versus what the Twilight theme can produce in the console (light purple). I am not sure if this meets user expectations.