feat(nautobot-target-proxy): Moves nautobot-target-proxy in to Understack#1957
feat(nautobot-target-proxy): Moves nautobot-target-proxy in to Understack#1957nicholaskuechler wants to merge 4 commits into
Conversation
b424584 to
e599634
Compare
62e2f22 to
be5b67e
Compare
be5b67e to
4f9faec
Compare
| annotations: | ||
| argocd.argoproj.io/sync-options: Delete=false | ||
| syncOptions: | ||
| - CreateNamespace=true |
There was a problem hiding this comment.
The namespace is probably created by the site worker so we don't want this line.
There was a problem hiding this comment.
I question whether it matters, but if it does matter, I think the assumption that nautobot-worker creates it is wrong, since nautobot-target-proxy comes before nautobot-worker alphabetically.
There was a problem hiding this comment.
It's not alphabetical. It's by sync order and this should come after.
| managedNamespaceMetadata: | ||
| annotations: | ||
| argocd.argoproj.io/sync-options: Delete=false |
There was a problem hiding this comment.
We won't want this if the namespace is created by the site worker
There was a problem hiding this comment.
Doesn't this protect against deletions which is what we want?
There was a problem hiding this comment.
No it doesn't. It just creates a fight for ownership.
b5a465c to
ca31da3
Compare
ca31da3 to
6db2c54
Compare
4a97cc2 to
911e7a6
Compare
93ef7a2 to
adfe658
Compare
… in to understack repo
adfe658 to
d389af9
Compare
cardoe
left a comment
There was a problem hiding this comment.
Overall I still think this is the wrong way to monitor the hardware. The metrics endpoint for many servers that Nidhi is working on is the better tool.
Uh oh!
There was an error while loading. Please reload this page.