media: i2c: arducam_64mp: Fix crop sizes for 9152x6944 and 8000x6000 - #7652
Merged
Merged
Conversation
The analog crop reported for these two modes uses the full pixel array size (9248x6944), but the register settings read a smaller area: - 8000x6000 reads x 624-8623, y 472-6471 unbinned (0x0344-0x034a), so the crop is 8000x6000 at the existing offset. - 9152x6944 reads the full array and then keeps the first 9152 columns (0x0408 = 0, 0x040c = 9152), so the crop is 9152x6944 at offset 0. Tested on a Pi 5: each mode's image was located inside a full-array capture, confirming the position and 1:1 scale. Link: raspberrypi#7650 Signed-off-by: Carlos Beltran <cbeltran@managingcomposites.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analog crop reported for these two modes uses the full pixel array size (9248x6944), but the register settings read a smaller area:
Tested on a Pi 5: each mode's image was located inside a full-array capture, confirming the position and 1:1 scale.
Link: #7650
Replaces #7651, which was closed automatically by a bad force-push on my side.