Add picotool help topics - #342
Conversation
|
maybe worth renaming "device selection" at least the heading/docs (not the help option) to indicate that it has other stuff like reboot |
I have updated it to "Options for Target Device Selection and Rebooting" |
|
Perhaps the "Show general help or help for a specific command" now ought to say "Show general help, or help for a specific command or topic". |
Move device selection options into a separate picotool help device-selection command, rather than appearing in every help output Also add a family-ids topic to list available family IDs (fixes #305)
Add docs for `version` and remove ALLOWED_MISSING_COMMANDS "Post load actions" -> "Load options" set/get -> get/set Fix white-label -s option not showing up Fix otp permissions docs
gen_help_txt.sh tidyups Add topic mention to picotool help docs Missing comma in block devices docs
Fixes things like --family <family_id> appearing on separate lines Also ensures short and long options are shown in the help output
…tout Also ensure all lines end in full-stops
…ool help uf2` etc
503fe3f to
226098d
Compare
|
|
||
| Use "picotool help <cmd>" for more info | ||
| TOPICS: | ||
| device-selection Options for Target Device Selection and Rebooting |
There was a problem hiding this comment.
The selection of Capital letters here feels a Bit Random? 🤔
There was a problem hiding this comment.
It’s just title case
| -s, --set <key> <value> | ||
| Set config variable name to new value |
There was a problem hiding this comment.
Outside the scope of this PR, but if picotool config allows you to set the value of a particular config key, it'd probably also be useful if it allowed you to get the value of a single config key?
| Specify the OTP page storing the AES key (IV salt is stored on the next page) | ||
| <page> | ||
| OTP page (default 29) | ||
| --otp-key-page <page> |
There was a problem hiding this comment.
Does this command fail if given an otp-key-page but not an otp JSON filename? (And similarly does it fail if given an otp JSON filename but not an otp-key-page?)
And presumably the --sign command fails if not given a <signing_key>?
Hmm, is the <signing_key> option of the encrypt command the same thing as the <key> option of the seal command? (If they are, perhaps it makes sense to rename seal's option for consistency?)
There was a problem hiding this comment.
Does this command fail if given an
otp-key-pagebut not anotpJSON filename? (And similarly does it fail if given anotpJSON filename but not anotp-key-page?)
No - both of those are entirely valid use-cases (the key page is in the binary, not just the JSON file, and has a default value when not provided)
And presumably the
--signcommand fails if not given a<signing_key>?
Yes, that does fail with missing key file for signing after encryption
Hmm, is the
<signing_key>option of theencryptcommand the same thing as the<key>option of thesealcommand? (If they are, perhaps it makes sense to renameseal's option for consistency?)
They are the same, but seal only takes 1 key, whereas encrypt takes a signing key and an encryption key, hence having different names
| Specify file type (elf) explicitly, ignoring file extension | ||
| Partition Table Options | ||
| --sign <keyfile> | ||
| The file name |
There was a problem hiding this comment.
Should "The file name" here be "Signing Key file (.pem)" ?
Hmm, should the <bootloader> option's "The file name" text be clarified too?
There was a problem hiding this comment.
Have fixed up the keyfile, the bootloader file is documented above as "Embed partition table into bootloader ELF"
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
3 participants
The device selection options have got quite long, so move them into a separate
picotool help device-selectioncommand, rather than appearing in every help outputAlso add a family-ids topic to list available family IDs (fixes #305)
Also makes various improvements to the help output.