Skip to content

fix(sdk): drop the invoice count from the delete blocker message - #1926

Closed
whoAbhishekSah wants to merge 1 commit into
mainfrom
fix/sdk-invoice-blocker-plural
Closed

fix(sdk): drop the invoice count from the delete blocker message#1926
whoAbhishekSah wants to merge 1 commit into
mainfrom
fix/sdk-invoice-blocker-plural

Conversation

@whoAbhishekSah

Copy link
Copy Markdown
Member

When more than one invoice is unpaid, the delete blocker message now reads:

Please pay your outstanding invoices before deleting this workspace.

It used to include the number, as in "your 3 outstanding invoices". The single-invoice sentence is unchanged.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
frontier Ready Ready Preview Sep 10, 2026 6:27am UTC

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4d11938f-79e1-422e-9faa-de702dfb80e8

📥 Commits

Reviewing files that changed from the base of the PR and between 1c282de and e5493d9.

📒 Files selected for processing (2)
  • web/sdk/client/utils/delete-blockers.test.ts
  • web/sdk/client/utils/delete-blockers.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Updated deletion-blocker messaging for multiple unpaid invoices to use clear plural wording without displaying the invoice count.

Walkthrough

The plural unpaid-invoice blocker message no longer includes the invoice count. The related comment and test now reflect the count-free wording.

Changes

Unpaid invoice blocker wording

Layer / File(s) Summary
Update blocker message and validation
web/sdk/client/utils/delete-blockers.ts, web/sdk/client/utils/delete-blockers.test.ts
The plural unpaid-invoice message and its explanatory comment no longer reference blocker counts. The test expects “Please pay your outstanding invoices before deleting this workspace.”

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e5493

For workspaces with multiple unpaid invoices, the deletion blocker now omits the invoice count while preserving the singular message. The updated behavior is covered without remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 34445219344

Coverage remained the same at 50.229%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 41106
Covered Lines: 20647
Line Coverage: 50.23%
Coverage Strength: 16.0 hits per line

💛 - Coveralls

@whoAbhishekSah

Copy link
Copy Markdown
Member Author

Closing. The screenshot that prompted this was taken from a tab still running the previous bundle. The current wording is fine as it is.

@whoAbhishekSah
whoAbhishekSah deleted the fix/sdk-invoice-blocker-plural branch September 10, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants