RDKCOM-5580: RDKBDEV-3433 RDKBWIFI-202 Implementation of Traffic Separation#263
Open
siddharth-nair-dtdl wants to merge 1 commit into
Open
RDKCOM-5580: RDKBDEV-3433 RDKBWIFI-202 Implementation of Traffic Separation#263siddharth-nair-dtdl wants to merge 1 commit into
siddharth-nair-dtdl wants to merge 1 commit into
Conversation
Contributor
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
amarnathhullur
suggested changes
Apr 3, 2026
|
|
||
| bridge vlan del vid 1 dev wifi0 | ||
| bridge vlan del vid 1 dev wifi0.1 | ||
| bridge vlan del vid 1 dev wifi02 |
There was a problem hiding this comment.
there seems to be a typo as wifi02, there is already wifi0.2 in the below line
| iptables -I INPUT -i brlan0.$vlan_mesh -p udp --dport 67:68 -j ACCEPT | ||
| iptables -I INPUT -i brlan0.$vlan_mesh -p udp --sport 67:68 -j ACCEPT | ||
| iptables -I INPUT -i brlan0.$vlan_iot -p udp --dport 67:68 -j ACCEPT | ||
| iptables -I INPUT -i brlan0.$vlan_iot -p udp --sport 67:68 -j ACCEPT |
| /*const char* SERVICE_CUSTOM_EVENTS[] = { | ||
| "lan-status|/etc/utopia/service.d/service_xhs.sh", | ||
| "multinet_2-status|/etc/utopia/service.d/service_xhs.sh", | ||
| "ipv4_5-status|/etc/utopia/service.d/service_xhs.sh", |
sundar2k
changed the title
pradeeptakdas
changed the title
|
Few places indentation need to be corrected, Can you please fix the review comments? |
siddharth-nair-dtdl
force-pushed
the
RDKBWIFI-202
branch
from
250ee7c to
2bd1a5a
Compare
|
@siddharth-nair-dtdl |
|
@AkhilaReddyK7 - We have updated the changes requested two weeks back. Can you please review the changes ? |
AkhilaReddyK7
force-pushed
the
RDKBWIFI-202
branch
from
2bd1a5a to
9575cef
Compare
Reason for change: Added traffic seperation TLV implementation via single bridge Test Procedure: Verify build is successfull and check if traffic seperation is functional Risks: Medium Priority: P2
AkhilaReddyK7
force-pushed
the
RDKBWIFI-202
branch
from
9575cef to
f08351f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a new vlan_ts (VLAN traffic separation) service intended to configure bridge VLAN filtering, per-SSID VLAN sub-interfaces, and inter-VLAN isolation rules, with new syscfg defaults and a service registration binary so the service can be managed by srvmgr.
Changes:
- Added
service_vlan_ts.shto configure bridge VLANs, create VLAN subinterfaces, and apply iptables + dnsmasq changes. - Added default syscfg tuples for VLAN IDs on ARM.
- Added
16_vlan_ts.cto register/unregister thevlan_tsservice withsrvmgr.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
source/scripts/init/service.d/service_vlan_ts.sh |
New service handler that configures bridge VLAN filtering, IPs, firewall rules, and modifies dnsmasq configuration. |
source/scripts/init/defaults/system_defaults_arm |
Adds default syscfg tuples for VLAN IDs used by the new service. |
source/scripts/init/c_registration/16_vlan_ts.c |
New srvmgr registration binary for the vlan_ts service. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+270
to
+272
| +$$vlan_id_pvt =12 | ||
| +$$vlan_id_mesh=13 | ||
| +$$vlan_id_iot=14 |
Comment on lines
+1
to
+3
| SERVICE_NAME="vlan_ts" | ||
| source /etc/utopia/service.d/ulog_functions.sh | ||
| source /etc/utopia/service.d/ut_plat.sh |
| vlan_mesh=`syscfg get vlan_id_mesh` | ||
| vlan_iot=`syscfg get vlan_id_iot` | ||
|
|
||
| echo "service_start : START" >> /tmp/abc.txt |
| vlan_mesh=`syscfg get vlan_id_mesh` | ||
| vlan_iot=`syscfg get vlan_id_iot` | ||
|
|
||
| echo "service_stop : START " >> /tmp/abc.txt |
|
|
||
|
|
||
| service_init() { | ||
| echo "service_init : START " >> /tmp/abc.txt |
Comment on lines
+35
to
+37
| ifconfig brlan0.$vlan_pvt 192.168.13.1 netmask 255.255.255.0 up | ||
| ifconfig brlan0.$vlan_mesh 192.168.14.1 netmask 255.255.255.0 up | ||
| ifconfig brlan0.$vlan_iot 192.168.15.1 netmask 255.255.255.0 up |
Comment on lines
+39
to
+45
| const char* SERVICE_NAME = "vlan_ts"; | ||
| const char* SERVICE_DEFAULT_HANDLER = "/etc/utopia/service.d/service_vlan_ts.sh"; | ||
| const char* SERVICE_CUSTOM_EVENTS[] = { NULL }; | ||
|
|
||
| void srv_register(void) { | ||
| sm_register(SERVICE_NAME, SERVICE_DEFAULT_HANDLER, SERVICE_CUSTOM_EVENTS); | ||
| } |
| switch(choice) { | ||
| case(nochoice): | ||
| case(start): | ||
| printf("%s %d : case start \n", __func__,__LINE__); |
| srv_register(); | ||
| break; | ||
| case(stop): | ||
| printf("%s %d : case stop \n", __func__,__LINE__); |
| srv_unregister(); | ||
| break; | ||
| case(restart): | ||
| printf("%s %d : case restart \n", __func__,__LINE__); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added traffic seperation TLV implementation via single bridge
Test Procedure: Verify build is successfull and check if traffic seperation is functional
Dependency: rdkcentral/OneWifi#972
Risks: Medium
Priority: P2