-
-
Notifications
You must be signed in to change notification settings - Fork 9
fix: align toolbar and modal button geometry with system controls #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ce78459
fix: align toolbar button geometry with system controls
rdlabo 945135d
fix: preserve toolbar hit areas and opt-out spacing
rdlabo f48c844
fix: retain full-size close icons in toolbar buttons
rdlabo 2166f4f
fix: retain intrinsic width for single toolbar icons
rdlabo 3822579
refactor: defer redundant toolbar styling to Ionic defaults
rdlabo 250cce8
chore: update E2E screenshots
github-actions[bot] 9d584f6
fix: preserve toolbar opt-out spacing and back icon sizing
rdlabo 41961d7
chore: update E2E screenshots
github-actions[bot] 5c47966
chore: drop imperceptible screenshot changes
rdlabo 722a04c
fix: preserve standalone and mixed toolbar button geometry
rdlabo ac95c76
chore: update E2E screenshots
github-actions[bot] fec6e8c
fix: exclude hidden back buttons from toolbar spacing
rdlabo 639a6a0
fix: align grouped toolbar spacing and visible slot boundaries
rdlabo c8bd858
chore: update E2E screenshots
github-actions[bot] 956f4c3
docs: note toolbar back-button class removal in v2.0.0
rdlabo 1c45e56
fix: exclude empty toolbar groups from action spacing
rdlabo d81c6cf
chore: update E2E screenshots
github-actions[bot] 3cf5192
chore: remove imperceptible segment snapshot change
rdlabo d71c60c
fix: preserve search spacing and modal safe areas
rdlabo 4298c2d
fix: keep centered card modal headers at a 10px inset
devin-ai-integration[bot] dc83f89
chore: update searchbar E2E screenshots
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-76 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/duo-split-menu-flat.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-71 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/duo-split-menu-half-open.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/modal-normal-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-90 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/modal-sheet-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-15 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/select-modal-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+995 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/vertical-bars-back-button-ltr.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+983 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/vertical-bars-back-button-rtl.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-53 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/vertical-bars-toolbar-actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 モーダルの上余白は端末種別ではなく画面寸法で切り替わる
幅768px以上かつ高さ600px以上なら上余白は0px、それ以外は6pxです。横向きや分割表示で想定する配置を確認してください。
Was this helpful? React with 👍 or 👎 to provide feedback.