fix: ignore bubbled transitionend when emulating transition end - #206
Open
BDanyil wants to merge 1 commit into
Open
fix: ignore bubbled transitionend when emulating transition end#206BDanyil wants to merge 1 commit into
BDanyil wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184
A
transitionendbubbling from a child node setscalled = true, which cancels the fallback timer. react-bootstrap'stransitionEndListenerignores events whose target isn't the element, so when the element itself never fires (e.g. Bootstrap'stransition: noneunderprefers-reduced-motion) the transition never completes and modals get stuck open. See react-bootstrap/react-bootstrap#6153Only count the event as seen when it was fired on the element itself
Added a test that fires a bubbling
transitionendfrom a child and checks the emulated event still arrives. Fails on master, passes with the change