chore: update maintenance dependencies by afc163 · Pull Request #1235 · react-component/select

afc163 · 2026-06-29T10:25:57Z

Summary

Link the Ant Design ecosystem logo in README files to https://ant.design
Update React, React DOM, TypeScript, ESLint, Testing Library, @types/, @typescript-eslint/, lint-staged, and related lint dependencies
Add ESLint flat config compatibility for ESLint 9 and TypeScript ESLint 8
Use grouped Dependabot updates for npm and GitHub Actions

Test Plan

npm run lint
npm run tsc

vercel · 2026-06-29T10:26:02Z

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/react-component?upgradeToPro=build-rate-limit

coderabbitai · 2026-06-29T10:26:07Z

Warning

Review limit reached

@afc163, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3bdb687d-658a-4c51-8a49-986eb1a9aae5

📥 Commits

Reviewing files that changed from the base of the PR and between 6c396cb and 95dcb86.

⛔ Files ignored due to path filters (1)

tests/__snapshots__/ssr.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (10)

.github/dependabot.yml
README.md
README.zh-CN.md
eslint.config.mjs
global.d.ts
package.json
react-compat.d.ts
src/utils/legacyUtil.ts
src/utils/warningPropsUtil.ts
tsconfig.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/update-maintenance-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

gemini-code-assist

Code Review

This pull request upgrades the project to React 19 and TypeScript 6, introduces an ESLint flat configuration, and adds type compatibility declarations. While these changes facilitate the upgrade, several issues were identified regarding type safety and configuration. Specifically, disabling strict type-checking flags in tsconfig.json and globally overriding standard React types in react-compat.d.ts reduces codebase robustness and can cause type conflicts. Additionally, declaring test globals as any in global.d.ts overrides strongly-typed Jest definitions, a redundant type cast was found in legacyUtil.ts, and the custom ESLint rule filtering logic may silently discard intended TypeScript rules.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-29T10:27:05Z

+  if (next.rules) {
+    next.rules = Object.fromEntries(
+      Object.entries(next.rules).filter(([ruleName]) => {
+        if (!ruleName.startsWith('@typescript-eslint/')) {
+          return true;
+        }
+        return recommendedTsRules.has(ruleName) || ruleName === '@typescript-eslint/ban-types';
+      }),
+    );
+  }


This filtering logic silently discards any custom @typescript-eslint rules configured in .eslintrc.js that are not part of the recommended set. This can lead to unexpected behavior where intended lint rules are silently disabled without warning.

Instead of silently filtering rules in a helper function, consider explicitly disabling or overriding specific rules in the flat config array, or updating .eslintrc.js to remove deprecated rules.

gemini-code-assist · 2026-06-29T10:27:05Z

+declare const describe: any;
+declare const it: any;
+declare const test: any;
+declare const beforeEach: any;
+declare const afterEach: any;
+declare const beforeAll: any;
+declare const afterAll: any;
+declare const expect: any;


These global declarations override the strongly-typed Jest globals (provided by the <reference types="jest" /> directive at the top of the file) with any. This disables type safety and autocompletion in test files. Removing these declarations will restore proper typing for your tests.

gemini-code-assist · 2026-06-29T10:27:05Z

+declare module 'react' {
+  type ReactText = string | number;
+  function useRef<T = undefined>(): React.MutableRefObject<T | undefined>;
+  function isValidElement<P = any>(object: {} | null | undefined): object is React.ReactElement<P>;
+  function cloneElement<P = any>(
+    element: React.ReactElement<P>,
+    props?: (Partial<P> & React.Attributes) | null,
+    ...children: React.ReactNode[]
+  ): React.ReactElement<P>;
+}


Overriding standard React types globally via ambient module declaration (declare module 'react') is highly discouraged. It can cause subtle type conflicts for consumers of this library, especially when they use different React or TypeScript versions, or have strictNullChecks enabled.

Instead of global module augmentation, consider using local type assertions or utility types within the codebase where compatibility adjustments are needed.

gemini-code-assist · 2026-06-29T10:27:05Z

+    "noImplicitAny": false,
+    "strictNullChecks": false,
+    "strictPropertyInitialization": false,
+    "strictFunctionTypes": false,
+    "strict": false,
+    "noImplicitThis": false,
+    "strictBindCallApply": false


Disabling strict type checking flags (strict, strictNullChecks, noImplicitAny, etc.) reduces type safety and increases the risk of runtime errors (such as TypeError: Cannot read properties of undefined).

While upgrading to React 19 and TypeScript 6 can introduce type challenges, it is highly recommended to keep strict checks enabled and resolve the type errors properly to maintain codebase robustness.

socket-security · 2026-06-29T10:27:18Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@typescript-eslint/parser@8.62.1
	npm/@types/react-dom@19.2.3
	npm/@types/react@19.2.17
	npm/@eslint/eslintrc@3.3.5
	npm/eslint-config-prettier@10.1.8
	npm/@testing-library/dom@10.4.1
	npm/@testing-library/react@16.3.2
	npm/@eslint/js@9.39.4
	npm/typescript@6.0.3
	npm/eslint-plugin-unicorn@65.0.1
	npm/lint-staged@17.0.8
	npm/eslint-plugin-react-hooks@7.1.1
	npm/eslint@9.39.4
	npm/eslint-plugin-jest@29.15.4
	npm/@typescript-eslint/eslint-plugin@8.62.1

View full report

socket-security · 2026-06-29T10:27:20Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

github-actions · 2026-06-29T10:29:49Z

❌ Deploy failed

	❌ Failed
	🔗 Preview ~~https://react-component-select-preview-pr-1235.surge.sh~~ _{(may be unavailable)}
	📝 Commit	`5f5786a`
	🪵 Logs	View logs

📋 Build log (last lines)

npm warn exec The following package was not found and will be installed: surge@0.27.4

   Running as afc163@gmail.com (Student)

        project: ./docs-dist
         domain: react-component-select-preview-pr-1235.surge.sh
           size: 151 files, 2.2 MB

   Aborted - you do not have permission to publish to react-component-select-preview-pr-1235.surge.sh

_{🤖 Powered by surge-preview}

vercel · 2026-06-30T02:21:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
select	Ready	Preview, Comment	Jun 30, 2026 2:57am

github-actions · 2026-06-30T02:56:06Z

React Doctor skipped this pull request — it changed no React files.

_{Reviewed by React Doctor for commit 5f5786a.}

coderabbitai · 2026-06-30T02:56:23Z

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/update-maintenance-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-06-30T03:23:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.44%. Comparing base (6c396cb) to head (95dcb86).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1235   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          31       31           
  Lines        1271     1271           
  Branches      444      466   +22     
=======================================
  Hits         1264     1264           
  Misses          7        7

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chore: update maintenance dependencies

22f29ec

gemini-code-assist Bot reviewed Jun 29, 2026

View reviewed changes

fix: align TypeScript and ESLint compatibility

26d3e8e

vercel Bot deployed to Preview June 30, 2026 02:30 View deployment

chore: use testing-library dom events

d0b16cc

vercel Bot deployed to Preview June 30, 2026 02:57 View deployment

test: keep react testing event behavior

5f5786a

afc163 added 3 commits June 30, 2026 19:04

chore: address review comments

2bc3527

fix: keep compatible eslint export rule

bc8c10a

chore: address review suggestion

95dcb86

Uh oh!

Uh oh!

Conversation

afc163 commented Jun 29, 2026

Summary

Test Plan

Uh oh!

vercel Bot commented Jun 29, 2026

Uh oh!

coderabbitai Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

socket-security Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy failed

Uh oh!

vercel Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 30, 2026

Review failed

Uh oh!

codecov Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Jun 29, 2026 •

edited

Loading

socket-security Bot commented Jun 29, 2026 •

edited

Loading

socket-security Bot commented Jun 29, 2026 •

edited

Loading

github-actions Bot commented Jun 29, 2026 •

edited

Loading

vercel Bot commented Jun 30, 2026 •

edited

Loading

github-actions Bot commented Jun 30, 2026 •

edited

Loading

codecov Bot commented Jun 30, 2026 •

edited

Loading