Repository navigation
fix: ignore failed segment measurements - #923
Open
huytdps13400 wants to merge 1 commit into
Open
huytdps13400 wants to merge 1 commit into
huytdps13400 wants to merge 1 commit into
Conversation
huytdps13400
force-pushed
the
fix/ignore-failed-segment-measurements
branch
from
October 5, 2026 06:54
abc5131 to
733e3c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
An unsuccessful Android
measurerequest can invoke its callback without arguments, as shown in React Native's MeasureOperation. The control currently divides the missing width by the number of segments and sendsNaNtoAnimated.Value.setValue, including when that callback arrives after unmount.Ignore measurements with an absent width. Successful measurements, including zero, still update the control. A failed measurement preserves the last valid segment width, and subsequent layout events continue to work. The callback type now reflects that width may be absent.
Fixes #897.
Test Plan
NaNto Animated; 4 control cases pass. After: all 7 tests pass, covering failure before layout, after a successful measurement, and after unmount, plus zero width, valid sizing, changing segment count, and recovery throughonLayout.--bracket-same-line, matching the repository's legacy formatting setting.spawnerror -86). No device/browser crash reproduction or Flow success is claimed; the failure callback and NaN propagation are verified at the component boundary.