Repository navigation
Keep side effects in sequence operands when folding constants #2278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
robhogan
merged 1 commit into
react:main
from
burrows99:fix/constant-folding-sequence-side-effects
Nov 22, 2026
+46
−10
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit · Property access in a leading sequence operand is still dropped
The check is a deny-list, so some leading operands that can still have effects are folded away. The closest to real minifier output is a member access:
if ((o.x, false)) { a(); }still becomes nothing. That drops a getter call, or theTypeErrorthrown whenois nullish.(`${o}`, false)(which callstoString) and("x" in p, false)(which runs a Proxy trap) are dropped too. This isn't new in this PR, and these cases are rarer thann++. If you want the sequence case closed off fully, check that the leading operands are pure, for examplepath.get('expressions').slice(0, -1).every(p => p.scope.isPure(p.node))in aSequenceExpressionentry. That is an allow-list, so it handles cases nobody thought to list. Otherwise, the comment could say which cases the list deliberately leaves out.Reproduced: A probe test (
packages/metro-transform-plugins/src/__tests__/review-probe-test.js, run in both checkouts) printed the plugin's output. Head and base both reduceif ((o.x, false)) { a(); },if ((`${o}`, false)) { a(); }andif (("x" in p, false)) { a(); }to empty output. Head keeps(i++, false),!(i++, 1),typeof (i++, 1)and(i++, 1) ?? 2, all of which base folded. · id0b01608a