chore: Convert RefreshControl to function component - #57187
Open
retyui wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Callstack
retyui
force-pushed
the
RefreshControl-fn-comp
branch
from
September 10, 2026 12:15
38bcf99 to
ca92dc0
Compare
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
retyui
commented
Sep 10, 2026
| }; | ||
| } | ||
|
|
||
| export type RefreshControlInstance = RefreshControl; |
Contributor
Author
There was a problem hiding this comment.
RefreshControlInstance is not a class instance anymore!
ref is forwarded down to native components (PullToRefreshViewNativeComponent or AndroidSwipeRefreshLayoutNativeComponent)
retyui
force-pushed
the
RefreshControl-fn-comp
branch
from
September 10, 2026 12:23
ca92dc0 to
81ead7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As per title.
Changelog:
[GENERAL] [CHANGED] - Convert
RefreshControlto function componentTest Plan:
node_modules/react-native/Libraries/Components/RefreshControl/RefreshControl.jswith code from this PR