Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ react.runtime=automatic

experimental.deprecated_utilities.excludes=<PROJECT_ROOT>/packages/react-native/Libraries/Renderer/shims/ReactNativeTypes.js
experimental.deprecated_utilities.excludes=<PROJECT_ROOT>/packages/react-native/Libraries/Renderer/shims/ReactNativeViewConfigRegistry.js
experimental.deprecated_colon_extends.excludes=<PROJECT_ROOT>/packages/react-native/Libraries/Renderer/shims/ReactNativeTypes.js
experimental.deprecated_variance_sigils.excludes=<PROJECT_ROOT>/packages/react-native/Libraries/Renderer/shims/ReactNativeTypes.js

ban_spread_key_props=true

[lints]
Expand All @@ -90,4 +93,4 @@ untyped-import
untyped-type-import

[version]
^0.318.0
^0.319.0
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"clean": "node ./scripts/build/clean.js",
"cxx-api-build": "python -m scripts.cxx-api.parser",
"cxx-api-validate": "python -m scripts.cxx-api.parser --validate",
"flow-check": "flow check",
"flow-check": "flow full-check",
"flow": "flow",
"format-check": "prettier --list-different \"./**/*.{js,md,yml,ts,tsx}\"",
"format": "npm run prettier && npm run clang-format",
Expand Down Expand Up @@ -86,7 +86,7 @@
"eslint-plugin-relay": "^1.8.3",
"fb-dotslash": "0.5.8",
"flow-api-translator": "0.36.1",
"flow-bin": "^0.318.0",
"flow-bin": "^0.319.0",
"hermes-eslint": "0.36.1",
"hermes-transform": "0.36.1",
"ini": "^5.0.0",
Expand Down
9 changes: 1 addition & 8 deletions scripts/run-ci-javascript-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,12 @@
* --maxWorkers [num] - how many workers, default 1
* --jestBinary [path] - path to jest binary, defaults to local node modules
* --yarnBinary [path] - path to yarn binary, defaults to yarn
* --flowBinary [path] - path to flow binary, defaults to running `yarn run flow-check`
*/

const {execSync} = require('child_process');
const argv /*:Readonly<{
maxWorkers?: number,
jestBinary?: string,
flowBinary?: string,
yarnBinary?: string,
}> */ =
// $FlowFixMe[incompatible-type]
Expand All @@ -34,7 +32,6 @@ const argv /*:Readonly<{
const numberOfMaxWorkers = argv.maxWorkers ?? 1;

const JEST_BINARY = argv.jestBinary ?? './node_modules/.bin/jest';
const FLOW_BINARY = argv.flowBinary;
const YARN_BINARY = argv.yarnBinary ?? 'yarn';

class ExecError extends Error {
Expand All @@ -61,11 +58,7 @@ try {
execAndLog(`${YARN_BINARY} run build-types --validate`);

describe('Test: Flow check');
const flowCommand =
FLOW_BINARY == null
? `${YARN_BINARY} run flow-check`
: `${FLOW_BINARY} full-check`;
execAndLog(flowCommand);
execAndLog(`${YARN_BINARY} run flow-check`);

/*
* Build @react-native/codegen and @react-native/codegen-typescript-test
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4810,10 +4810,10 @@ flow-api-translator@0.36.1:
hermes-transform "0.36.1"
typescript "5.3.2"

flow-bin@^0.318.0:
version "0.318.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.318.0.tgz#a9fca88958c361255c3939b7a0ab7db6ab4feaf3"
integrity sha512-Q4Z1lrjgBeGNwQEdlD3bJNtjU00bAwgM+HDKQF2kH0gB6ZmEx72kOfYZyL2iok/MIiHqfxU9RhugUqH3ue7YjA==
flow-bin@^0.319.0:
version "0.319.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.319.0.tgz#7ff6c2c531b4d8bd13ec8fecf69e8964f14b6499"
integrity sha512-cl14ZCtILLYmrSW60hoSNfChiA5Og0xacKhqTiSDfSnhJd0P7jLip8IziGE7bOnOi5JIGo+tOlniibkXmckb/w==

flow-enums-runtime@^0.0.6:
version "0.0.6"
Expand Down
Loading