Skip to content

Skip dropped mapped node in PropsAnimatedNode.updateView instead of crashing #57298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shashank-bhatotia wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Skip dropped mapped node in PropsAnimatedNode.updateView instead of crashing #57298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .../react-native/ReactAndroid/src/main/java/com/facebook/react/animated/PropsAnimatedNode.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,15 @@ internal class PropsAnimatedNode(
}
for ((key, value) in propNodeMapping) {
val node = nativeAnimatedNodesManager.getNodeById(value)
requireNotNull(node) { "Mapped property node does not exist" }
// A mapped child node can be dropped (e.g. its component unmounted during
// navigation) between animation frames while this prop node is still
// queued for an update. Skip the stale node instead of throwing: the
// connected view is being torn down, so there is no meaningful value to
// write for this prop on this frame. Mirrors the connectedViewTag == -1
// early-return above. Fixes #37267.
if (node == null) {
continue
}
if (node is StyleAnimatedNode) {
node.collectViewUpdates(propMap)
} else if (node is ValueAnimatedNode) {
Expand Down