Add Fantom test verifying onLayout does not bubble to ancestors#57444
Closed
rubennorte wants to merge 1 commit into
Closed
Add Fantom test verifying onLayout does not bubble to ancestors#57444rubennorte wants to merge 1 commit into
onLayout does not bubble to ancestors#57444rubennorte wants to merge 1 commit into
Conversation
Summary: `onLayout` is a direct (non-bubbling) event, so a layout event fired on a child should not invoke an ancestor's `onLayout` prop handler. Add a Fantom integration test that renders a parent and child `<View>`, both with `onLayout`, then dispatches a layout event on the child and asserts the parent's `onLayout` prop is not called as a result. The initial layout pass emits a real layout event for every view that has `onLayout`, and those events are flushed lazily on the first dispatched event. The test flushes them up front and snapshots the call counts before dispatching, so the parent's own mount-time layout event is not mistaken for bubbling. Changelog: [Internal] Differential Revision: D110755346
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110755346. |
|
This pull request has been merged in 2e36e63. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
onLayoutis a direct (non-bubbling) event, so a layout event fired on a child should not invoke an ancestor'sonLayoutprop handler. Add a Fantom integration test that renders a parent and child<View>, both withonLayout, then dispatches a layout event on the child and asserts the parent'sonLayoutprop is not called as a result.The initial layout pass emits a real layout event for every view that has
onLayout, and those events are flushed lazily on the first dispatched event. The test flushes them up front and snapshots the call counts before dispatching, so the parent's own mount-time layout event is not mistaken for bubbling.Changelog: [Internal]
Differential Revision: D110755346