Narrow nativemodule/core cxxreact dep to tracesection + module#57445
Closed
javache wants to merge 3 commits into
Closed
Narrow nativemodule/core cxxreact dep to tracesection + module#57445javache wants to merge 3 commits into
javache wants to merge 3 commits into
Conversation
Summary:
Move `handleJSError` from `cxxreact/ErrorUtils.h` (header-inline) to `jserrorhandler/ErrorUtils.{h,cpp}` (declared + linked). Inverts the cyclic dep so `jserrorhandler` becomes a standalone leaf and `cxxreact:bridge` can be narrowed out of more consumers in follow-ups.
The old `<cxxreact/ErrorUtils.h>` include path continues to work via a deprecated `#warning` forwarder header that includes the new location. `cxxreact:bridge` now depends on `jserrorhandler:jserrorhandler` so existing consumers of the deprecated path still link cleanly. `jserrorhandler/BUCK` drops its `cxxreact:bridge` dep (and the matching `React-cxxreact` podspec entry).
Changelog:
[Internal]
Differential Revision: D108786498
Summary: Narrow the runtimescheduler's cxxreact dep. Previously runtimescheduler depended on the full `cxxreact:bridge` target; it only needs `cxxreact:tracesection` (for `TraceSection.h`) plus `jserrorhandler:jserrorhandler` (for `handleJSError`, since Phase 1 moved `ErrorUtils` there) plus `jsi` directly. Also adds `jsi` to the explicit dep list — `runtimescheduler` was previously pulling it in transitively through `cxxreact:bridge`. Verified with `buck2 uquery 'somepath(...:runtimeschedulerAndroid, ...:bridgeAndroid)'` — no path; the edge is gone. Changelog: [Internal] Differential Revision: D108786501
Summary: Drop the broad `cxxreact:bridge` dep from `nativemodule/core` in favor of the narrower pieces it actually needs: `cxxreact:tracesection` for `TraceSection.h`, plus the already-present `cxxreact:module`. Also extracts `MoveWrapper` to `react/utils/MoveWrapper.h` (a tiny stdlib-only utility) — it was previously living in `cxxreact:bridge` and is the one source-level dep that prevented the narrowing. The cxxreact copy remains in place (out of scope for this diff) but `JavaTurboModule.cpp` now uses the new location. Cleanup: drops dead `exclude_patterns` for `CallbackWrapper.h` / `LongLivedObject.h` from `exported_headers` (those files no longer exist) and collapses multi-line glob formatting. Verified with `buck2 uquery 'somepath(...:coreAndroid, ...:cxxreact:bridgeAndroid)'` — no path; the edge is gone. Changelog: [Internal] Reviewed By: zeyap Differential Revision: D108786500
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108786500. |
|
This pull request has been merged in 703e362. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Drop the broad
cxxreact:bridgedep fromnativemodule/corein favor of the narrower pieces it actually needs:cxxreact:tracesectionforTraceSection.h, plus the already-presentcxxreact:module.Also extracts
MoveWrappertoreact/utils/MoveWrapper.h(a tiny stdlib-only utility) — it was previously living incxxreact:bridgeand is the one source-level dep that prevented the narrowing. The cxxreact copy remains in place (out of scope for this diff) butJavaTurboModule.cppnow uses the new location.Cleanup: drops dead
exclude_patternsforCallbackWrapper.h/LongLivedObject.hfromexported_headers(those files no longer exist) and collapses multi-line glob formatting.Verified with
buck2 uquery 'somepath(...:coreAndroid, ...:cxxreact:bridgeAndroid)'— no path; the edge is gone.Changelog:
[Internal]
Reviewed By: zeyap
Differential Revision: D108786500