fix(podspec): remove duplicate scrollview subspec in React-FabricComponents#57452
Open
Saadnajmi wants to merge 1 commit into
Open
fix(podspec): remove duplicate scrollview subspec in React-FabricComponents#57452Saadnajmi wants to merge 1 commit into
Saadnajmi wants to merge 1 commit into
Conversation
…onents The `scrollview` subspec is declared in both `React-Fabric.podspec` (recursive `scrollview/**/*` glob) and `React-FabricComponents.podspec`, so the same source files land in both Pods targets and produce duplicate symbol errors when both libraries are linked (e.g. via `-all_load`). `React-Fabric.podspec`'s recursive glob already covers everything FabricComponents listed (top-level + `platform/cxx` + `platform/ios`), so remove the duplicate subspec from `React-FabricComponents.podspec`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream version of our react-native-macos fix (microsoft#2969).
The
scrollviewsubspec is declared in bothReact-Fabric.podspec(recursivescrollview/**/*glob) andReact-FabricComponents.podspec(scrollview/*+platform/cxx+platform/ios). The globs overlap, so afterpod installthesame sources (
ScrollViewShadowNode.cpp,BaseScrollViewProps.cpp,ScrollEvent.cpp, etc.) land in both theReact-FabricandReact-FabricComponentsPods targets, and consumers that link both (e.g. via-all_load) hit duplicate symbol errors.React-Fabric.podspec's recursive glob already covers everythingFabricComponents listed, so this removes the duplicate subspec.
Note on SPM: the SPM manifest (
Package.swift) handles scrollview differently —it's assigned solely to the
React-Fabrictarget, with no FabricComponentsscrollview target. This is an existing divergence between the CocoaPods and SPM
setups; this PR only touches CocoaPods, so SPM is unaffected.
Test Plan
CI should pass.