Simplify react-native/setup-env require in community-cli-plugin#57498
Closed
huntie wants to merge 1 commit into
Closed
Simplify react-native/setup-env require in community-cli-plugin#57498huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
Summary: **Motivation** While sanity checking react#57492, I double checked why we use `path.join(ctx.reactNativePath, ...)` here when adjacent OOT platforms resolve by package name. It turns out this complexity is historic and redundant: - `reactNativePath` doesn't customize the `react-native` package name — it only resolves the `node_modules` directory. [[1]](https://github.com/react-native-community/cli/blame/main/packages/cli-tools/src/findPackageDependencyDir.ts#L81) - We now (since ~2 years ago) resolve using `{paths: [ctx.root]}`, making the manual `path.join` redundant. **This diff** Drops the `reactNativePath` option and resolves `react-native/setup-env` directly by package name. Purely a refactor. No need to pick to 0.87. Changelog: [Internal] Differential Revision: D111225671
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111225671. |
|
This pull request has been merged in 4237f1a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
While sanity checking #57492, I double checked why we use
path.join(ctx.reactNativePath, ...)here when adjacent OOT platforms resolve by package name.It turns out this complexity is historic and redundant:
reactNativePathdoesn't customize thereact-nativepackage name — it only resolves thenode_modulesdirectory. [1]{paths: [ctx.root]}, making the manualpath.joinredundant.This diff
Drops the
reactNativePathoption and resolvesreact-native/setup-envdirectly by package name.Purely a refactor. No need to pick to 0.87.
Changelog: [Internal]
Differential Revision: D111225671