[0.88] Restore Touchable public API - #58419
Open
cipolleschi wants to merge 1 commit into
Open
Conversation
This reverts commit 6fbf306.
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Restores the
Touchableroot export and its Flow/TypeScript API surface for React Native 0.88 so the release remains non-breaking.The original removal in 0015d1e was reverted and then re-landed as 6fbf306. This reverts the effective re-landed commit. No later commit depends on the removed export.
Changelog:
[GENERAL][FIXED] - Restore the Touchable root export and types in React Native 0.88.
Test Plan:
yarn build-types— passedyarn test-generated-typescript— passed./node_modules/.bin/prettier --check packages/react-native/__typetests__/index.tsx packages/react-native/index.js packages/react-native/index.js.flow packages/react-native/ReactNativeApi.d.ts— passedgit diff --checkandgit diff --cached --check— passed