Fix builds to not probe Maven for 1000.0.0 versioned artifacts - #58425
Open
coado wants to merge 2 commits into
Open
Fix builds to not probe Maven for 1000.0.0 versioned artifacts#58425coado wants to merge 2 commits into
1000.0.0 versioned artifacts#58425coado wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes issue with probing Maven Central repo for artifacts with version
1000.0.0which are not stored there. The reason is that it creates most of the traffic on Maven Mirror that is forwarded to Maven Central due to artifacts not being cached because they are not found. After this change:Changelog:
[GENERAL][FIXED] - Changed builds to not probe Maven for
1000.0.0versioned artifacts.Test Plan:
Ran
pod installand build the HelloWorld workspace:Ran SwiftPM setup on a disposable copy of HelloWorld and built the generated Xcode project.
Published
react-android:1000.0.0to/tmp/maven-local, then ran the repository’s real HelloWorld Android build and a verbose Gradle rebuild.During the HelloWorld build: