Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
AbortSignal.any()currently connects its inputs through public abort listeners. An earlier listener can stop event propagation and leave the combined signal active after its source is cancelled. It can also observe stale cancellation state, or trigger a second source that incorrectly replaces the first abort reason.Track dependent signals internally and mark all of them aborted before dispatching the source's event. Dispatch the dependent events afterward, in registration order. Flattening nested combinations preserves the same ordering through chains; weak source references and cleanup avoid retaining inputs after cancellation.
This follows the DOM signal-abort algorithm. The failures reproduce headlessly on React Native 0.88.0 and current main.
Before:
second. After:first, matching native behavior.Changelog:
[GENERAL] [FIXED] - Preserve
AbortSignal.any()cancellation state and the first abort reason before source abort listeners run.Test Plan:
From the repository root:
All four tests pass. Running these tests against the unchanged main implementation fails all four assertions: propagation suppression, state during the source event, nested event order, and the reentrant first reason.
ESLint, formatting, and focused Flow checking pass. Additional headless probes of the real runtime passed with native event dispatch enabled and disabled, including nested combinations, duplicate inputs, validation failures, and reference cleanup.
The existing Fantom
any()test now runs insideFantom.runTaskbecause Fantom requires WeakRef construction and dereferencing inside its event loop. Fantom, native builds, the full Jest suite, and full-repository Flow checking were not run.