Repository navigation
Fix getOutlineWidth returning the outline offset - #59467
Closed
Abbondanzo wants to merge 1 commit into
Closed
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
Summary: `BackgroundStyleApplicator.getOutlineWidth` returned `outlineOffset` instead of `outlineWidth`, so readers got the offset value (or null when only a width was set). Return the width. Changelog: [Android][Fixed] - Fix `getOutlineWidth` returning the outline offset Differential Revision: D127479548
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127479548. |
Visual regressionNo visual differences at ios: no capture |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in 54b5f22 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 54b5f22. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
BackgroundStyleApplicator.getOutlineWidthreturnedoutlineOffsetinstead ofoutlineWidth, so readers got the offset value (or null when only a width was set). Return the width.Changelog:
[Android][Fixed] - Fix
getOutlineWidthreturning the outline offsetDifferential Revision: D127479548