Repository navigation
Prevent stale mounting revisions from recreating removed views - #59468
Open
DorianMazur wants to merge 1 commit into
Open
DorianMazur wants to merge 1 commit into
DorianMazur wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A delayed revision can reach
MountingCoordinator::pushafter a newer revision has already been pulled. Since pulling clearslastRevision_, the older revision is accepted and the next transaction can recreate a removed view.Reject revisions older than
baseRevision_under the existing mutex. Equal revisions retain their existing behavior.Changelog:
[ANDROID] [FIXED] - Prevent stale mounting revisions from recreating removed views during concurrent commits.
Test Plan:
Run the two added cases in
MountingCoordinatorTest.cppwith a native C++ test harness:lateRevisionDoesNotRecreateRemovedView: after revision 3 removes a view, a delayed revision 2 must produce no transaction or change to the base; revision 4 must still be accepted.lateRevisionPreservesNewerPendingRevision: an older push must not replace a newer pending revision.Locally ran
./mounting_coordinator_tests --gtest_filter='MountingCoordinatorTest.*': both pass with the fix. Without the guard, the first regression fails.The executable was built with a temporary local CMake/gtest harness, which is not included in this PR; this is not a repository-provided test command. Execution of these tests in upstream CI has not been verified.