Skip to content

Fix: unmounted secureTextEntry TextInput retained (with its Activity) by the measurement cache #59470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A-Kimpo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: unmounted secureTextEntry TextInput retained (with its Activity) by the measurement cache #59470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...act-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ import android.text.TextUtils
import android.text.TextWatcher
import android.text.method.KeyListener
import android.text.method.QwertyKeyListener
import android.text.style.CharacterStyle
import android.text.style.ParagraphStyle
import android.util.TypedValue
import android.view.ActionMode
import android.view.DragEvent
Expand Down Expand Up @@ -1242,6 +1244,12 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
} catch (e: IndexOutOfBoundsException) {
logSoftException(TAG, e)
}
// The copy only feeds measurement, so drop editor bookkeeping spans. Some of them reference
// this view's Editable (PasswordTransformationMethod.Visible), and the cache is evicted only
// from finalize(), so keeping them would keep this view reachable for good.
stripSpansOfKind(sb, Any::class.java) { span ->
span !is CharacterStyle && span !is ParagraphStyle && span !is ReactSpan
}
}

// If we don't have text, make sure we have *something* to measure.
Expand Down
Loading