[lazerg]

Summary:

On Android (Fabric), a secureTextEntry TextInput that got input is never released after it unmounts. updateCachedSpannable() copies the text with all its spans into TextLayoutManager's cache, and that includes PasswordTransformationMethod.Visible, which holds the view's Editable and through it the view and its Activity. The cache entry is only removed in finalize(), which can't run while the cache keeps the view alive.

The cached copy is only used for measurement, so it now drops every span that isn't a CharacterStyle, ParagraphStyle or ReactSpan right after copying the text, as suggested in the issue.

Fixes #59469

Changelog:

[ANDROID] [FIXED] - Fix secureTextEntry TextInput staying in memory after unmount

Test Plan:

Added ReactEditTextCachedSpannableTest, which types into a password field with "show password" on and checks the cached spannable has no PasswordTransformationMethod spans. It fails on main and passes with this change.

./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest --tests "com.facebook.react.views.textinput.*" --tests "com.facebook.react.views.text.*"

All views.text and views.textinput tests pass.

[github-actions]

Visual regression

No visual differences at f1628af6b15b.

ios: no capture