Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
Visual regressionNo visual differences at ios: no capture |
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D127564742. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
If the Activity is destroyed while a reload is still running,
ReactHostImplfinishes the reload by callingmoveToOnHostResume(reactContext, currentActivity)withcurrentActivityalready null. The new context getsonHostResume(null)and the lifecycle state becomesRESUMED, so when the app is reopenedonHostResume(activity)returns early andgetCurrentActivity()stays null until the next pause/resume. That's what makesPermissionsAndroid.request()reject withE_INVALID_ACTIVITY(and likely theAlerterror in #46201).The reload branch now only resumes the context when there is an Activity. Otherwise it falls through to the normal path, and the next
onHostResume(activity)resumes the context with the right Activity.Fixes #59473
Changelog:
[ANDROID] [FIXED] - Fix
getCurrentActivity()staying null after the Activity is destroyed during a reloadTest Plan:
Added
ReactHostTest.testActivityDestroyedDuringReload. It queues background work so the Activity can be paused and destroyed before the reload finishes, then resumes a new Activity and checks the new context gets it. Onmainit fails (state isRESUMEDand the context only gotonHostResume(null)), and it passes with this change../gradlew :packages:react-native:ReactAndroid:testDebugUnitTestpasses and ktfmt is clean. I didn't run the reproducer on a device.