Repository navigation
Conversation
Visual regressionNo visual differences at android: no capture |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On iOS, an RTL horizontal
ScrollViewis mirrored, so its UIKit offset counts from the right edge.scrollToandonScrollconverted it, but thecontentOffsetprop andScrollViewStatedid not. As a result,measurereturned wrong x values (#55153), and the prop andscrollToshowed different pages (#58534).Offsets now count from the left edge everywhere on iOS, like Android. Android code paths are unchanged.
Fixes #55153
Fixes #58534
Changelog:
[IOS] [FIXED] - Fix
measure,measureInWindowand thecontentOffsetprop in RTL horizontalScrollViewTest Plan:
Added two RNTester examples under ScrollView, "in RTL measure" and "in RTL contentOffset". Ran them on the iOS simulator:
measureInWindowx (button at 46)-43446contentOffset={{x: 600}}vsscrollTo({x: 600})