Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
marked this pull request as ready for review
October 26, 2026 14:05
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D127579075. |
|
@cortinico merged this pull request in 859d9b8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The iOS Maestro
sectionlist-viewabilityflow is repeatedly failing on main when it waits forCheesecakeinoutput, for example https://github.com/react/react-native/actions/runs/40321872438. The test currently stops scrolling once 50% of the item is visible, while the RNTester example setsviewAreaCoveragePercentThreshold: 100. Require full item visibility before asserting that the example reported it. Remove the redundant centering requirement so the scroll can stop at the visibility condition.This is a targeted test-stability hypothesis; the draft PR CI must confirm it on the iOS simulator. If the 100% condition cannot be reached reliably, the PR should not be merged as-is.
Changelog:
[INTERNAL] [FIXED] - Align the SectionList viewability flow with the example visibility threshold.
Test Plan:
yarn prettier --check packages/rn-tester/.maestro/sectionlist-viewability.yml— passed.git diff --check— passed.