Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
Visual regressionNo visual differences at ios: no capture |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The settings plugin caches
autolinking.jsonwith absolute paths and only regenerates it when a lockfile changes or the cache is empty/invalid. Moving or copying the project keeps the lockfile hashes the same, so the next build still links every library from the old folder (and fails if that folder is gone).isCacheDirtynow also treats the cache as dirty when the cachedproject.android.sourceDirisn't the Gradle root directory of the build being configured, so the config command reruns after a move.Fixes #59503
Changelog:
[ANDROID] [FIXED] - Refresh the autolinking cache when the project folder is moved or copied
Test Plan:
Added
checkAndUpdateConfigIfCachedConfigIsFromAnotherProjectDirtoReactSettingsExtensionTest, which fails before this change and passes after it../gradlew :settings-plugin:testinpackages/gradle-pluginpasses.