Repository navigation
Verify Fantom screenshot failure reporting (#59507) - #59507
Open
rubennorte wants to merge 5 commits into
Open
rubennorte wants to merge 5 commits into
rubennorte wants to merge 5 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127588525. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D127588525
branch
from
October 26, 2026 16:07
af2ed51 to
62f61d0
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59507 Verification only. This diff is not intended to be published or landed. Change the feed heading from `Feed` to `Feed!` while preserving the screenshot baseline, so an existing test deliberately fails and exercises failure propagation and reporting. Differential Revision: D127588525
Summary: Avoid repeated warnings when a new root matches the current global dimensions, even if older roots have different metrics. Continue warning when another root is alive and the new root changes the current metrics. Changelog: [Internal] Compare Fantom root dimensions against current global metrics. Differential Revision: D127606984
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
Summary: Pull Request resolved: react#59483 Integrate screenshots into Fantom's existing Jest snapshot workflow so tests catch visual regressions while PNG baselines remain easy to inspect. Immutable captures make comparisons across React updates reliable. Share Skia and fonts with text measurement to keep layout and painting consistent across Linux and macOS. Pixel hashes make comparisons independent of PNG encoding; saved captures and highlighted differences make failures inspectable in CI and terminals without image support. Changelog: [Internal] Add Skia screenshot snapshots to Fantom. Differential Revision: D126888504
Summary: Pull Request resolved: react#59498 Make visual regressions easier to inspect with Expected | Received | Difference previews and file paths. A Jest reporter reuses the saved PNGs without changing snapshot comparison. Terminal formatting preserves the full results for logs and other reporters. Select the protocol from the detected terminal and confirm VS Code image support before sending graphics. Keep full text diagnostics whenever a required preview cannot be shown. Retain failing comparison images as GitHub job artifacts to diagnose rendering differences in CI. Keep captures from every failed retry, even if a later attempt passes. Changelog: [Internal] Show terminal previews and upload GitHub artifacts for failing Fantom screenshot snapshots. Differential Revision: D127129237
Summary: Pull Request resolved: react#59507 Verification only. This diff is not intended to be published or landed. Change the feed heading from `Feed` to `Feed!` while preserving the screenshot baseline, so an existing test deliberately fails and exercises failure propagation and reporting. Changelog: [Internal] Verify Fantom screenshot failure reporting. Differential Revision: D127588525
rubennorte
force-pushed
the
export-D127588525
branch
from
October 26, 2026 17:04
62f61d0 to
c9b3280
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Verification only. This diff is not intended to be published or landed.
Change the feed heading from
FeedtoFeed!while preserving the screenshot baseline, so an existing test deliberately fails and exercises failure propagation and reporting.Changelog: [Internal] Verify Fantom screenshot failure reporting.
Differential Revision: D127588525