Skip to content

Restore async-iterable Node return types - #59550

Merged
meta-codesync[bot] merged 1 commit into
react:mainfrom
cortinico:export-D127844351
Oct 30, 2026
Merged

Restore async-iterable Node return types#59550
meta-codesync[bot] merged 1 commit into
react:mainfrom
cortinico:export-D127844351

Conversation

@cortinico

@cortinico cortinico commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Summary:
Restore the previous AsyncIteratorObject return types for fs.promises.glob, fs.promises.watch, and timers/promises.setInterval in the Node Flow libdef.

Changelog: [Internal]

Differential Revision: D127844351

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2026
@meta-codesync

meta-codesync Bot commented Oct 27, 2026

Copy link
Copy Markdown

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127844351.

@github-actions

github-actions Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Visual regression

No visual differences at 3f757bba0fdc.

android: no capture

@cortinico

cortinico commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/rebase

@cortinico
Restore async-iterable Node return types
be89f80 
Summary:
Restore the previous `AsyncIteratorObject` return types for `fs.promises.glob`, `fs.promises.watch`, and `timers/promises.setInterval` in the Node Flow libdef.

Changelog: [Internal]

Differential Revision: D127844351
@meta-codesync

meta-codesync Bot commented Oct 29, 2026

Copy link
Copy Markdown

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D127844351.

@meta-codesync
meta-codesync Bot merged commit 4afc5d5 into react:main Oct 30, 2026
98 checks passed
@react-native-bot

react-native-bot commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 4afc5d5

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 30, 2026
@react-native-bot

react-native-bot commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 4afc5d5

When will my fix make it into a release? | How to file a pick request?

4 similar comments
@react-native-bot

react-native-bot commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 4afc5d5

When will my fix make it into a release? | How to file a pick request?

@react-native-bot

react-native-bot commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 4afc5d5

When will my fix make it into a release? | How to file a pick request?

@react-native-bot

react-native-bot commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 4afc5d5

When will my fix make it into a release? | How to file a pick request?

@react-native-bot

react-native-bot commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 4afc5d5

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javache javache javache approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cortinico @react-native-bot @javache