feat: combine the binding and attribute source generators

.gitattributes

@@ -1,13 +1,28 @@
-# Text files are stored and checked out with LF line endings on every platform.
-# Files are UTF-8 without a byte order mark; .editorconfig sets that for editors.
+# Every text file is stored and checked out with LF, on every platform.
+#
+# Without this, a Windows checkout with core.autocrlf=true rewrites LF to CRLF
+# on the way to disk. The line-ending analyzer then fails the whole build on the
+# Windows leg while the Linux and macOS legs pass, because the files on disk no
+# longer match what is in the repository. `eol=lf` pins the checkout, so the
+# working tree matches the index everywhere.
+#
+# The .editorconfig already sets end_of_line = lf for editors; this is the same
+# rule for git, which editors do not control.
 * text=auto eol=lf
 
-# Binary files are never normalised.
+# Never normalise binary content — a stray LF-to-CRLF pass corrupts it.
 *.png binary
 *.jpg binary
+*.jpeg binary
+*.gif binary
 *.ico binary
+*.pdf binary
 *.snk binary
+*.pfx binary
 *.dll binary
 *.exe binary
+*.zip binary
 *.nupkg binary
-*.nettrace binary
+*.ttf binary
+*.woff binary
+*.woff2 binary

.github/renovate.json

@@ -4,15 +4,25 @@
         "local>reactiveui/.github:renovate"
     ],
     "packageRules": [
+        {
+            "description": "The generator and analyzer are held at the Roslyn 4.8.0 baseline (VS 2022 17.8, .NET 8.0.1xx SDK) and must not move with the toolchain. Both ship in the version-less analyzers/dotnet/cs folder, and a compiler refuses to load a generator or analyzer built against a newer Roslyn than itself, so raising this floor silently drops every consumer on an older SDK. It is a compatibility decision, not a maintenance lag, and the only reason to change it is to raise the minimum supported SDK on purpose. Microsoft.CodeAnalysis.Analyzers is deliberately absent: it supplies analyzer-authoring rules and has no bearing on the load floor.",
+            "matchManagers": [
+                "nuget"
+            ],
+            "enabled": false,
+            "matchPackageNames": [
+                "/^Microsoft\\.CodeAnalysis\\.CSharp$/",
+                "/^Microsoft\\.CodeAnalysis\\.CSharp\\.Workspaces$/"
+            ]
+        },
         {
             "description": "Analyzer packages all gate the build through the same warnings-as-errors pass, so landing them separately just means several red CI runs in a row. Move them in one PR.",
             "matchManagers": [
                 "nuget"
             ],
             "groupName": "analyzers",
             "matchPackageNames": [
-                "/^Roslynator\\./",
-                "/^stylecop\\.analyzers$/i"
+                "/^(Style|Performance|Security|PublicApi)Sharp\\.Analyzers$/"
             ]
         },
         {
@@ -27,14 +37,13 @@
             ]
         },
         {
-            "description": "Verify.TUnit is built against a specific TUnit version. The shared preset groups TUnit separately from Verify.*, which can split a matched pair across two PRs and red the build; keep them together here.",
+            "description": "Basic.Reference.Assemblies ships one package per target runtime and the generator tests compile against all of them. A partial bump leaves the suite straddling two versions.",
             "matchManagers": [
                 "nuget"
             ],
-            "groupName": "TUnit",
+            "groupName": "reference assemblies",
             "matchPackageNames": [
-                "/^TUnit(\\.|$)/",
-                "/^Verify\\./"
+                "/^Basic\\.Reference\\.Assemblies(\\.|$)/"
             ]
         },
         {
@@ -44,7 +53,7 @@
             ],
             "groupName": "test tooling",
             "matchPackageNames": [
-                "/^PublicApiGenerator$/"
+                "/^BenchmarkDotNet(\\.|$)/"
             ]
         }
     ]

.github/workflows/benchmarks-ab.yml

@@ -0,0 +1,30 @@
+name: Benchmarks A/B
+
+on:
+    workflow_dispatch:
+        inputs:
+            base:
+                description: 'Baseline commit SHA.'
+                type: string
+                required: true
+            head:
+                description: 'Commit SHA compared against the baseline.'
+                type: string
+                required: true
+
+permissions:
+    contents: read
+
+jobs:
+    benchmark:
+        uses: reactiveui/actions-common/.github/workflows/workflow-common-benchmarks-ab.yml@main
+        with:
+            base: ${{ inputs.base }}
+            head: ${{ inputs.head }}
+            projects: |
+                benchmarks/ReactiveUI.Binding.Benchmarks/ReactiveUI.Binding.Benchmarks.csproj
+                benchmarks/ReactiveUI.Binding.Generator.Benchmarks/ReactiveUI.Binding.Generator.Benchmarks.csproj
+                benchmarks/ReactiveUI.Binding.Analyzer.Benchmarks/ReactiveUI.Binding.Analyzer.Benchmarks.csproj
+                benchmarks/ReactiveUI.SourceGenerators.Benchmarks/ReactiveUI.SourceGenerators.Benchmarks.csproj
+            solutionFile: ReactiveUI.SourceGenerators.slnf
+            installWorkloads: true

.github/workflows/benchmarks.yml

@@ -0,0 +1,27 @@
+name: Benchmarks
+
+on:
+    workflow_dispatch:
+        inputs:
+            sha:
+                description: 'Commit to benchmark. Empty benchmarks the latest commit of the chosen branch.'
+                type: string
+                default: ''
+
+permissions:
+    contents: read
+
+jobs:
+    benchmark:
+        uses: reactiveui/actions-common/.github/workflows/workflow-common-benchmarks.yml@main
+        with:
+            revision: ${{ inputs.sha }}
+            projects: |
+                benchmarks/ReactiveUI.Binding.Benchmarks/ReactiveUI.Binding.Benchmarks.csproj
+                benchmarks/ReactiveUI.Binding.Benchmarks.ReactiveUI/ReactiveUI.Binding.Benchmarks.ReactiveUI.csproj
+                benchmarks/ReactiveUI.Binding.Generator.Benchmarks/ReactiveUI.Binding.Generator.Benchmarks.csproj
+                benchmarks/ReactiveUI.Binding.Analyzer.Benchmarks/ReactiveUI.Binding.Analyzer.Benchmarks.csproj
+                benchmarks/ReactiveUI.SourceGenerators.Benchmarks/ReactiveUI.SourceGenerators.Benchmarks.csproj
+                benchmarks/ReactiveUI.SourceGenerators.Runtime.Benchmarks/ReactiveUI.SourceGenerators.Runtime.Benchmarks.csproj
+            solutionFile: ReactiveUI.SourceGenerators.slnf
+            installWorkloads: true

.github/workflows/ci-build.yml

@@ -6,20 +6,23 @@ on:
   pull_request:
     branches: [ main ]
 
-env:
-  productNamespacePrefix: "ReactiveUI.SourceGenerators"
-
 # Needed so the reusable workflow can optionally delete the temp per-OS artifacts it creates.
 permissions:
   contents: read
   actions: write
 
+env:
+  productNamespacePrefix: "ReactiveUI"
+
 jobs:
   build:
     uses: reactiveui/actions-common/.github/workflows/workflow-common-setup-and-build.yml@main
     with:
-      productNamespacePrefix: ReactiveUI.SourceGenerators
+      configuration: Release
+      productNamespacePrefix: "ReactiveUI"
+      # The Uno.Sdk projects need MSBuild, so they build and test in their own Windows job.
+      solutionFile: ReactiveUI.SourceGenerators.slnf
+      msbuildSolutionFile: ReactiveUI.SourceGenerators.Uno.slnf
       installWorkloads: true
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-

.github/workflows/codeql.yml

@@ -1,15 +1,3 @@
-# For most projects, this workflow file will not need changing; you simply need
-# to commit it to your repository.
-#
-# You may wish to alter this file to override the set of languages analyzed,
-# or to provide custom queries or build logic.
-#
-# ******** NOTE ********
-# We have attempted to detect the languages in your repository. Please check
-# the `language` matrix defined below to confirm you have the correct set of
-# supported CodeQL languages.
-#
-
 name: "CodeQL Advanced"
 
 on:
@@ -18,7 +6,7 @@ on:
   pull_request:
     branches: [ main ]
   schedule:
-    - cron: '37 15 * * 3'
+    - cron: '18 12 * * 3'
 
 permissions:
   security-events: write
@@ -31,7 +19,7 @@ jobs:
     uses: reactiveui/actions-common/.github/workflows/workflow-common-codeql.yml@main
     with:
       srcFolder: src
-      solutionFile: ReactiveUI.SourceGenerators.slnx
+      solutionFile: ReactiveUI.SourceGenerators.slnf
       installWorkloads: true
       analyzeCSharp: true
       analyzeActions: true

.github/workflows/native-aot.yml

@@ -0,0 +1,16 @@
+name: Native AOT
+
+on:
+    push:
+        branches: [ main ]
+    pull_request:
+        branches: [ main ]
+
+permissions:
+    contents: read
+
+jobs:
+    native-aot-smoke:
+        uses: reactiveui/actions-common/.github/workflows/workflow-common-aot-smoke.yml@main
+        with:
+            projectFile: src/tests/ReactiveUI.Binding.AotValidation/ReactiveUI.Binding.AotValidation.csproj

.github/workflows/release-binding.yml

@@ -0,0 +1,77 @@
+name: Release ReactiveUI.Binding
+
+on:
+  workflow_dispatch:
+    inputs:
+      bump:
+        description: 'Release level'
+        required: true
+        type: choice
+        options:
+          - patch
+          - minor
+          - major
+
+      sourceRef:
+        description: 'Optional git ref (tag/branch/SHA) to release from. Leave blank to release from this branch (normally main).'
+        required: false
+        type: string
+        default: ''
+
+permissions:
+  contents: write
+  id-token: write
+  packages: read
+
+jobs:
+  release:
+    uses: reactiveui/actions-common/.github/workflows/workflow-common-release.yml@main
+    with:
+      solutionFile: ReactiveUI.Binding.slnf
+      msbuildSolutionFile: ReactiveUI.Binding.Uno.slnf
+      installWorkloads: true
+      minverTagPrefix: binding-v
+      minverMinimumMajorMinor: '9.2'
+      bump: ${{ inputs.bump }}
+      sourceRef: ${{ inputs.sourceRef }}
+    secrets:
+      CERTUM_USER_ID: ${{ secrets.CERTUM_USER_ID }}
+      CERTUM_OTP_URI: ${{ secrets.CERTUM_OTP_URI }}
+      CERTUM_CERT_FINGERPRINT: ${{ secrets.CERTUM_CERT_FINGERPRINT }}
+
+  publish-nuget:
+    needs: release
+    runs-on: ubuntu-latest
+    environment:
+      name: release
+    permissions:
+      id-token: write
+    steps:
+      - name: Download signed packages
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
+        with:
+          name: signed-nuget
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6
+
+      - name: NuGet login (OIDC trusted publishing)
+        id: nuget-login
+        uses: NuGet/login@8d196754b4036150537f80ac539e15c2f1028841 # v1.2.0
+        with:
+          user: ${{ secrets.NUGET_USER }}
+
+      - name: Push to NuGet
+        shell: bash
+        run: |
+          for pkg in *.nupkg; do
+            dotnet nuget push "$pkg" --source https://api.nuget.org/v3/index.json --api-key "${{ steps.nuget-login.outputs.NUGET_API_KEY }}"
+          done
+
+  create-release:
+    needs: [release, publish-nuget]
+    uses: reactiveui/actions-common/.github/workflows/workflow-common-create-release.yml@main
+    with:
+      version: ${{ needs.release.outputs.semver2 }}
+      tag: ${{ needs.release.outputs.tag }}
+      target: ${{ needs.release.outputs.sourceSha }}

.github/workflows/release.yml

@@ -1,4 +1,4 @@
-name: Release
+name: Release ReactiveUI.SourceGenerators
 
 on:
   workflow_dispatch:
@@ -27,9 +27,8 @@ jobs:
   release:
     uses: reactiveui/actions-common/.github/workflows/workflow-common-release.yml@main
     with:
-      solutionFile: ReactiveUI.SourceGenerators.slnx
-      installWorkloads: true
-      minverMinimumMajorMinor: '2.7'
+      solutionFile: ReactiveUI.SourceGenerators.Package.slnf
+      minverTagPrefix: v
       bump: ${{ inputs.bump }}
       sourceRef: ${{ inputs.sourceRef }}
     secrets:
@@ -46,7 +45,7 @@ jobs:
       id-token: write
     steps:
       - name: Download signed packages
-        uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
         with:
           name: signed-nuget
 

.github/workflows/sonarcloud.yml

@@ -0,0 +1,34 @@
+name: SonarCloud
+
+on:
+    push:
+        branches: [ main ]
+    pull_request:
+        branches: [ main ]
+
+permissions:
+    contents: read
+
+jobs:
+    sonarcloud:
+        uses: reactiveui/actions-common/.github/workflows/workflow-common-sonarcloud.yml@main
+        with:
+            productNamespacePrefix: ReactiveUI
+            solutionFile: ReactiveUI.SourceGenerators.slnf
+            installWorkloads: true
+            sonarProjectKey: ReactiveUI.Binding.SourceGenerators
+            sonarOrganization: reactiveui
+            sonarExclusions: '**/tests/**,**/benchmarks/**,**/TestResults/**'
+            sonarCoverageExclusions: '**/tests/**,**/benchmarks/**,**/examples/**,**/*Tests/**,**/*Tests.cs,**/*TestModels/**'
+            # Copy-paste detection is switched off for the arity-expanded surface and the platform packages.
+            # A *.WideArity.cs file is the same operator written once per type-parameter count, and the
+            # CombineLatest observables are one class per arity; each repetition is what makes the call site
+            # allocation-free and reflection-free, so collapsing them is not an option. The platform packages
+            # implement the same small abstractions against different UI frameworks.
+            sonarCpdExclusions: '**/tests/**,**/benchmarks/**,**/examples/**,**/*.WideArity.cs,**/*.WideArity.Unsafe.cs,**/Observables/CombineLatest*Observable.cs,**/ReactiveUI.Binding.Maui.Shared/**,**/ReactiveUI.Binding.Wpf.Shared/**,**/ReactiveUI.Binding.WinForms.Shared/**,**/ReactiveUI.Binding.Platform.Shared/**'
+            sonarTestExclusions: '**/tests/**,**/benchmarks/**,**/examples/**'
+            # Matches ci-build.yml: the MTP/TUnit suite is far slower on Windows net10
+            # than on net8/9, so allow generous headroom for the coverage run.
+            testTimeout: '15m'
+        secrets:
+            SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/trimmed.yml

@@ -0,0 +1,19 @@
+name: Trimmed
+
+# The shared smoke workflow keys its concurrency group on github.workflow, so the trimmed harness runs from
+# its own file. Both in one file share a group, and whichever starts second cancels the other.
+
+on:
+    push:
+        branches: [ main ]
+    pull_request:
+        branches: [ main ]
+
+permissions:
+    contents: read
+
+jobs:
+    trimmed-smoke:
+        uses: reactiveui/actions-common/.github/workflows/workflow-common-aot-smoke.yml@main
+        with:
+            projectFile: src/tests/ReactiveUI.Binding.TrimValidation/ReactiveUI.Binding.TrimValidation.csproj