[PHPUnit60] Count assertions outside the test method body in AddDoesNotPerformAssertionToNonAssertingTestRector

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/non_asserting_set_up.php.inc

@@ -0,0 +1,42 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class NonAssertingSetUp extends TestCase
+{
+    protected function setUp(): void
+    {
+        $this->value = 1;
+    }
+
+    public function testSomething()
+    {
+        $value = 5;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class NonAssertingSetUp extends TestCase
+{
+    protected function setUp(): void
+    {
+        $this->value = 1;
+    }
+
+    #[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
+    public function testSomething()
+    {
+        $value = 5;
+    }
+}
+
+?>

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/parent_test_call_without_assert.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source\AbstractClassWithNonAssertingMethod;
+
+class ParentTestCallWithoutAssert extends AbstractClassWithNonAssertingMethod
+{
+    public function testSomething()
+    {
+        parent::testSomething();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source\AbstractClassWithNonAssertingMethod;
+
+class ParentTestCallWithoutAssert extends AbstractClassWithNonAssertingMethod
+{
+    #[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
+    public function testSomething()
+    {
+        parent::testSomething();
+    }
+}
+
+?>

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_asserting_after_annotation.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class SkipAssertingAfterAnnotation extends TestCase
+{
+    /**
+     * @after
+     */
+    protected function cleanup(): void
+    {
+        $this->assertTrue(true);
+    }
+
+    public function testSomething()
+    {
+        $value = 5;
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_asserting_before_attribute.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use PHPUnit\Framework\Attributes\Before;
+use PHPUnit\Framework\TestCase;
+
+class SkipAssertingBeforeAttribute extends TestCase
+{
+    #[Before]
+    protected function prepare(): void
+    {
+        $this->assertTrue(true);
+    }
+
+    public function testSomething()
+    {
+        $value = 5;
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_asserting_own_post_conditions.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class SkipAssertingOwnPostConditions extends TestCase
+{
+    protected function assertPostConditions(): void
+    {
+        $this->assertTrue(true);
+    }
+
+    public function testSomething()
+    {
+        $value = 5;
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_asserting_set_up.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class SkipAssertingSetUp extends TestCase
+{
+    protected function setUp(): void
+    {
+        $this->assertTrue(true);
+    }
+
+    public function testSomething()
+    {
+        $value = 5;
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_asserting_tear_down_in_parent.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source\AbstractClassWithAssertingTearDown;
+
+class SkipAssertingTearDownInParent extends AbstractClassWithAssertingTearDown
+{
+    public function testSomething()
+    {
+        $value = 5;
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_expect_user_deprecation_message.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+class SkipExpectUserDeprecationMessageTest extends \PHPUnit\Framework\TestCase
+{
+    public function testExpectUserDeprecationMessage()
+    {
+        $this->expectUserDeprecationMessage('Since foo 1.0: Bar is deprecated.');
+
+        @trigger_error('Since foo 1.0: Bar is deprecated.', E_USER_DEPRECATED);
+    }
+
+    public function testExpectUserDeprecationMessageMatches()
+    {
+        $this->expectUserDeprecationMessageMatches('#^Since foo 1\.0#');
+
+        @trigger_error('Since foo 1.0: Bar is deprecated.', E_USER_DEPRECATED);
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_parent_test_call_with_assert.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source\AbstractClassWithAssertingMethod;
+
+class SkipParentTestCallWithAssert extends AbstractClassWithAssertingMethod
+{
+    public function testSomething()
+    {
+        parent::testSomething();
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_post_conditions_parent_call.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source\AbstractClassWithAssertingPostConditions;
+
+class SkipPostConditionsParentCall extends AbstractClassWithAssertingPostConditions
+{
+    protected function assertPostConditions(): void
+    {
+        parent::assertPostConditions();
+    }
+
+    public function testSomething()
+    {
+        $value = 5;
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Source/AbstractClassWithAssertingMethod.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source;
+
+use PHPUnit\Framework\TestCase;
+
+abstract class AbstractClassWithAssertingMethod extends TestCase
+{
+    public function testSomething()
+    {
+        $this->assertTrue(true);
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Source/AbstractClassWithAssertingPostConditions.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source;
+
+use PHPUnit\Framework\TestCase;
+
+abstract class AbstractClassWithAssertingPostConditions extends TestCase
+{
+    protected function assertPostConditions(): void
+    {
+        $this->assertTrue(true);
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Source/AbstractClassWithAssertingTearDown.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source;
+
+use PHPUnit\Framework\TestCase;
+
+abstract class AbstractClassWithAssertingTearDown extends TestCase
+{
+    protected function tearDown(): void
+    {
+        $this->assertTrue(true);
+    }
+}

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Source/AbstractClassWithNonAssertingMethod.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source;
+
+use PHPUnit\Framework\TestCase;
+
+abstract class AbstractClassWithNonAssertingMethod extends TestCase
+{
+    public function testSomething()
+    {
+        $value = 1 + 1;
+    }
+}

rules/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector.php

@@ -23,6 +23,7 @@
 use Rector\PHPUnit\Enum\PHPUnitAttribute;
 use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\PHPUnit\NodeAnalyzer\AssertCallAnalyzer;
+use Rector\PHPUnit\NodeAnalyzer\LifecycleMethodAssertAnalyzer;
 use Rector\PHPUnit\NodeAnalyzer\MockedVariableAnalyzer;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
@@ -57,6 +58,7 @@ public function __construct(
         private readonly PhpDocInfoFactory $phpDocInfoFactory,
         private readonly ReflectionResolver $reflectionResolver,
         private readonly ReflectionProvider $reflectionProvider,
+        private readonly LifecycleMethodAssertAnalyzer $lifecycleMethodAssertAnalyzer,
     ) {
     }
 
@@ -164,6 +166,11 @@ private function shouldSkipClassMethod(ClassMethod $classMethod): bool
             return true;
         }
 
+        // assertions in lifecycle methods count toward every test of the class
+        if ($this->lifecycleMethodAssertAnalyzer->hasAssertingLifecycleMethod($classMethod)) {
+            return true;
+        }
+
         return $this->mockedVariableAnalyzer->containsMockAsUsedVariable($classMethod);
     }
 

src/Enum/PHPUnitAttribute.php

@@ -33,4 +33,12 @@ final class PHPUnitAttribute
     public const string ALLOW_MOCK_OBJECTS_WITHOUT_EXPECTATIONS = 'PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations';
 
     public const string DATA_PROVIDER = 'PHPUnit\Framework\Attributes\DataProvider';
+
+    public const string BEFORE = 'PHPUnit\Framework\Attributes\Before';
+
+    public const string AFTER = 'PHPUnit\Framework\Attributes\After';
+
+    public const string PRE_CONDITION = 'PHPUnit\Framework\Attributes\PreCondition';
+
+    public const string POST_CONDITION = 'PHPUnit\Framework\Attributes\PostCondition';
 }