Repository navigation
[ci] Run AddDoesNotPerformAssertionToNonAssertingTestRector on Drupal core and its tests - #832
Open
TomasVotruba wants to merge 1 commit into
Open
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
… core and its tests
Member
Author
|
Lets address this here in one place @bbrala 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds standalone Drupal job to guard recent
AddDoesNotPerformAssertionToNonAssertingTestRectorchanges (#824, #825, #826) on real-world code.Steps:
zend.assertions=1)core/tests+core/modulesFunctional/FunctionalJavascript tests are skipped, they need web server/Chrome.
Current state - expected red
Locally on the pinned Drupal SHA: 40 files changed, unit suite green, but 29 kernel tests turn risky, e.g.
Causes, to be fixed in separate PRs:
setUp()/assertPostConditions()/tearDown()and their helper chains count for the test (e.g.UserCreationTrait::createUser()asserts)$this->$stream_assert(...)(ExtensionStreamTest)assertPostConditions()with asserts in the test class (KernelTestBaseShutdownTest)