Skip to content

[Parallel] Fix silently skipped files when the only worker is respawned - #8521

Merged
TomasVotruba merged 1 commit into
rectorphp:mainfrom
janwaleed09:fix/parallel-worker-respawn
Sep 30, 2026
Merged

TomasVotruba merged 1 commit into
rectorphp:mainfrom
janwaleed09:fix/parallel-worker-respawn

Conversation

@janwaleed09

@janwaleed09 janwaleed09 commented Sep 29, 2026 •

Copy link
Copy Markdown

With only 1 worker (default config on a machine with 1 CPU, or maxNumberOfProcess: 1), Rector stops after 144 files and still says "[OK]". The old worker was quit before the new one was started, so the TCP server was already closed and the new worker could not connect.

  • start the new worker first
  • report an error when results for some files are missing, e.g. after an OOM kill
  • no crash anymore when the limit of 50 errors is reached, and its message is shown again

3 new e2e tests, each fails on main.

@TomasVotruba
TomasVotruba merged commit eb8de9f into rectorphp:main Sep 30, 2026
50 checks passed
@TomasVotruba

Copy link
Copy Markdown
Member

Thank you

Let's ship it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants