[Performance] Resolve short names once per file version in ShortNameResolver::resolveFromFile() - #8525
Closed
TomasVotruba wants to merge 1 commit into
Closed
[Performance] Resolve short names once per file version in ShortNameResolver::resolveFromFile()#8525TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…esolver::resolveFromFile()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8524.
#8524 cached
resolveShortClassLikeNames()per file and per stmts version. Its siblingresolveFromFile()in the same class still cached by file path only, with no version check - so once a file was resolved, later passes kept getting the first-pass result even after the stmts changed. It is called per imported name byFullyQualifiedNameClassNameImportSkipVoter, in the same post-processing phase as the method #8524 fixed, so it had the same latent staleness.This aligns
resolveFromFile()with the pattern from #8524:Fileinstance andgetNewStmtsVersion(), recomputing when either changesAdded tests mirror the ones from #8524: cache recompute after a stmts change, and correct per-file resolution.