Skip to content

Add support/tests for 'MEGs in HGs' and Targeting Gate node #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-zhu-reddit merged 1 commit into from
Sep 24, 2026
Merged

Add support/tests for 'MEGs in HGs' and Targeting Gate node #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/python-package.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ jobs:
- python-version: '3.9'
reddit-decider-version: '1.18.1'
- python-version: '3.9'
reddit-decider-version: '1.19.0b1'
reddit-decider-version: '1.19.0b2'
- python-version: '3.10'
reddit-decider-version: '1.15.0'
- python-version: '3.10'
reddit-decider-version: '1.18.1'
- python-version: '3.10'
reddit-decider-version: '1.19.0b1'
reddit-decider-version: '1.19.0b2'

steps:
- uses: actions/checkout@v2
Expand Down
118 changes: 118 additions & 0 deletions tests/decider_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@

DECIDER_SUPPORTS_PROPERTY_REGISTRY = Version(package_version("reddit-decider")) >= Version("1.18.1")
DECIDER_SUPPORTS_COHORT_FIELDS = Version(package_version("reddit-decider")) >= Version("1.19.0b1")
DECIDER_SUPPORTS_TARGETING_GATES = Version(package_version("reddit-decider")) >= Version("1.19.0b2")
DECIDER_SUPPORTS_MEGS_IN_HOLDOUT_GROUPS = Version(package_version("reddit-decider")) >= Version(
"1.19.0b2"
)

COHORT_REGISTRY = {
"id": 1337,
Expand Down Expand Up @@ -648,6 +652,51 @@ def test_cohort_targeting_uses_typed_context_without_mutating_input(self):
self.assertEqual(fields, {"$cohort_power_users": membership})
self.assertEqual(ctx.to_dict()["other_fields"], fields)

@unittest.skipUnless(
DECIDER_SUPPORTS_TARGETING_GATES,
"targeting gates require reddit-decider 1.19.0b2 or newer",
)
def test_targeting_gate_controls_experiment(self):
config = deepcopy(self.exp_base_config)
config["minimum_build_gate"] = {
"id": 2,
"name": "minimum_build_gate",
"owner": "",
"enabled": True,
"version": "1",
"type": "targeting_gate",
"emit_event": False,
"start_ts": 0,
"stop_ts": 9999999999,
"experiment": {
"experiment_version": 1,
"targeting": {
"GE": {
"field": "build_number",
"value": 100,
}
},
},
}
config["exp_1"]["experiment"]["targeting"] = {
"gate": {
"name": "minimum_build_gate",
}
}

with create_temp_config_file(config) as f:
self.assertIsNone(init_manifest_validator("", f.name).err())

for build_number, expected in [(100, "variant_4"), (99, None)]:
with self.subTest(build_number=build_number):
ctx = DeciderContext(
user_id=USER_ID,
extracted_fields={"build_number": build_number},
)
decider = setup_decider(f, ctx, self.mock_span, self.event_logger)

self.assertEqual(decider.get_variant_without_expose("exp_1"), expected)

def test_none_returned_on_get_variant_call_with_bad_id(self):
config = {
"test": {
Expand Down Expand Up @@ -773,6 +822,75 @@ def test_get_variant_without_expose_for_holdout_exposure(self):
experiment_name="hg", variant="holdout", event_fields=event_fields
)

@unittest.skipUnless(
DECIDER_SUPPORTS_MEGS_IN_HOLDOUT_GROUPS,
"mutex groups in holdout groups require reddit-decider 1.19.0b2 or newer",
)
def test_mutex_group_in_holdout_group_preserves_holdout_exposure(self):
for holdout_variant, expected_variant in [
("control_1", "enabled"),
("holdout", None),
]:
with self.subTest(holdout_variant=holdout_variant):
holdout_group = deepcopy(self.parent_hg_config["hg"])
holdout_group["experiment"]["variants"] = [
{
"name": holdout_variant,
"range_start": 0.0,
"range_end": 1.0,
}
]

mutex_group = deepcopy(self.exp_base_config["exp_1"])
mutex_group.update(
{
"id": 3,
"name": "meg",
"parent_hg_name": "hg",
}
)
mutex_group["experiment"]["variants"] = [
{
"name": "child",
"range_start": 0.0,
"range_end": 1.0,
}
]

child = deepcopy(self.exp_base_config["exp_1"])
child.update(
{
"id": 4,
"name": "child",
"parent_meg_name": "meg",
}
)
child["experiment"]["variants"] = [
{
"name": "enabled",
"range_start": 0.0,
"range_end": 1.0,
}
]

config = {
"hg": holdout_group,
"meg": mutex_group,
"child": child,
}
self.event_logger.reset_mock()

with create_temp_config_file(config) as f:
decider = setup_decider(f, self.dc, self.mock_span, self.event_logger)
variant = decider.get_variant_without_expose("child")

self.assertEqual(variant, expected_variant)
self.assertEqual(self.event_logger.log.call_count, 1)
event_fields = self.event_logger.log.call_args[1]
self.assertEqual(event_fields["experiment"].id, holdout_group["id"])
self.assertEqual(event_fields["experiment"].name, holdout_group["name"])
self.assertEqual(event_fields["variant"], holdout_variant)

def test_get_variant_for_identifier_user_id(self):
identifier = USER_ID
bucket_val = "user_id"
Expand Down
Loading