Repository navigation
fix: retain setup.py metadata for modern builds - #129
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern build tools reject the partial
[project]table because it declares only a dynamic version and omits the required name. Bothpython -m build --no-isolationand an editable installation fail before package creation.Remove the incomplete table so package metadata continues to come from
setup.py, includinguse_scm_version=True. Retain the setuptools-scm configuration.Validation: reproduced the missing-name error using setuptools 84.0.0 and uv. With the change, the source archive and wheel build successfully, and editable installation succeeds. Inspected wheel metadata to verify the package name, SCM-derived version, Python requirement, all five dependency entries, and inclusion of the
reddit_deciderpackage.git diff --checkpasses. Runtime tests were not run for this packaging-only change.